From: Borislav Petkov <bp@alien8.de>
To: silviazhaooc <silviazhao-oc@zhaoxin.com>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, namhyung@kernel.org, tglx@linutronix.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
cobechen@zhaoxin.com, louisqi@zhaoxin.com,
silviazhao@zhaoxin.com, tonywwang@zhaoxin.com,
kevinbrace@gmx.com, 8vvbbqzo567a@nospam.xutrox.com
Subject: Re: [PATCH] x86/perf/zhaoxin: Add stepping check for ZX-C
Date: Tue, 7 Feb 2023 19:30:31 +0100 [thread overview]
Message-ID: <Y+KYx5XcE1IAPPoQ@zn.tnic> (raw)
In-Reply-To: <950c6d27-bc91-01e0-ba26-d09ad4bf7934@zhaoxin.com>
On Tue, Feb 07, 2023 at 04:42:26PM +0800, silviazhaooc wrote:
> Sorry, I'm a newbie in Linux. Thanks for your reminding.
No worries. :)
> I have carefully checked our product manual for Nano and ZXC FMS.
>
> For ZXC, there are 2 kinds of FMS：
>
> 1. Family=6, Model=0x19, Stepping=0-3
>
> 2. Family=6, Model=F, Stepping=E-F
>
> For Nano, there is only one kind of FMS:
>
> Family=6, Model=F, Stepping=[0-A]/[C-D]
>
> So model = 0xf, steppings >= 0xe or model = 0x19 belong solely to ZXC.
> Nano is an old CPU series which has been stopped production several years
> ago.
Good, which sounds like there won't be any more Nano steppings.
> It will not use the steppings which belong to ZXC.This is an
> unambiguous way to differentiate between ZXC and Nano CPUs.
>
> Do I need to add the statements in the source code and re-commit the patch?
Yes please. That would explain in a clear way why it is ok to test those
models/steppings. If it turns out that we need this Nano - ZXC
distinction more often, we can do something more involved later.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2023-02-07 18:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 9:17 [PATCH] x86/perf/zhaoxin: Add stepping check for ZX-C silviazhao-oc
2023-02-02 23:53 ` Kevin Brace
2023-02-03 3:12 ` silviazhaooc
2023-02-04 13:44 ` Borislav Petkov
2023-02-06 8:26 ` silviazhaooc
2023-02-06 9:48 ` Borislav Petkov
2023-02-06 10:55 ` silviazhaooc
2023-02-06 11:13 ` Borislav Petkov
2023-02-07 8:42 ` silviazhaooc
2023-02-07 18:30 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+KYx5XcE1IAPPoQ@zn.tnic \
--to=bp@alien8.de \
--cc=8vvbbqzo567a@nospam.xutrox.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=cobechen@zhaoxin.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=kevinbrace@gmx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=louisqi@zhaoxin.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=silviazhao-oc@zhaoxin.com \
--cc=silviazhao@zhaoxin.com \
--cc=tglx@linutronix.de \
--cc=tonywwang@zhaoxin.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox