From: Christoph Hellwig <hch@infradead.org>
To: Victor Hassan <victor@allwinnertech.com>
Cc: keescook@chromium.org, tony.luck@intel.com, gpiccoli@igalia.com,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] pstore/blk: Export a method to implemente panic_write()
Date: Tue, 7 Feb 2023 22:34:07 -0800 [thread overview]
Message-ID: <Y+NCXyT8EM0G0xU3@infradead.org> (raw)
In-Reply-To: <20230206061813.44506-1-victor@allwinnertech.com>
On Mon, Feb 06, 2023 at 02:18:13PM +0800, Victor Hassan wrote:
> The panic_write() is necessary to write the pstore frontend message
> to blk devices when panic. Here is a way to register panic_write when
> we use "best_effort" way to register the pstore blk-backend.
This looks like a really awkware interface. And without also posting
the users it not only has no chance to ever be merged, but also robs
us of a good way to try to help you to find a better interface.
prev parent reply other threads:[~2023-02-08 6:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 6:18 [PATCH v2] pstore/blk: Export a method to implemente panic_write() Victor Hassan
2023-02-08 6:34 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+NCXyT8EM0G0xU3@infradead.org \
--to=hch@infradead.org \
--cc=gpiccoli@igalia.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=victor@allwinnertech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox