From: Sean Christopherson <seanjc@google.com>
To: shahuang@redhat.com
Cc: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
Shuah Khan <shuah@kernel.org>,
Andrew Jones <andrew.jones@linux.dev>,
Marc Zyngier <maz@kernel.org>,
David Matlack <dmatlack@google.com>,
Ricardo Koller <ricarkol@google.com>,
Ben Gardon <bgardon@google.com>,
Vipin Sharma <vipinsh@google.com>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KVM: selftests: Remove duplicate macro definition
Date: Wed, 8 Feb 2023 15:00:53 +0000 [thread overview]
Message-ID: <Y+O5JW+Ro3i7iXV3@google.com> (raw)
In-Reply-To: <20230208071801.68620-1-shahuang@redhat.com>
On Wed, Feb 08, 2023, shahuang@redhat.com wrote:
> From: Shaoqin Huang <shahuang@redhat.com>
>
> The KVM_GUEST_PAGE_TABLE_MIN_PADDR macro has been defined in
> include/kvm_util_base.h. So remove the duplicate definition in
> lib/kvm_util.c.
>
> Signed-off-by: Shaoqin Huang <shahuang@redhat.com>
> ---
> tools/testing/selftests/kvm/lib/kvm_util.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c
> index f25b3e9b5a07..3ea24a5f4c43 100644
> --- a/tools/testing/selftests/kvm/lib/kvm_util.c
> +++ b/tools/testing/selftests/kvm/lib/kvm_util.c
> @@ -1942,9 +1942,6 @@ vm_paddr_t vm_phy_page_alloc(struct kvm_vm *vm, vm_paddr_t paddr_min,
> return vm_phy_pages_alloc(vm, 1, paddr_min, memslot);
> }
>
> -/* Arbitrary minimum physical address used for virtual translation tables. */
> -#define KVM_GUEST_PAGE_TABLE_MIN_PADDR 0x180000
Huh. There wasn't even a merge conflict or anything, I just added it twice in
commit cce0c23dd944 ("KVM: selftests: Add wrapper to allocate page table page").
Anyways, applied to kvm-x86 selftests with a Fixes tag. Thanks!
[1/1] KVM: selftests: Remove duplicate macro definition
https://github.com/kvm-x86/linux/commit/695fa5a64cf5
--
https://github.com/kvm-x86/linux/tree/next
https://github.com/kvm-x86/linux/tree/fixes
prev parent reply other threads:[~2023-02-08 15:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 7:18 [PATCH] KVM: selftests: Remove duplicate macro definition shahuang
2023-02-08 15:00 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+O5JW+Ro3i7iXV3@google.com \
--to=seanjc@google.com \
--cc=andrew.jones@linux.dev \
--cc=bgardon@google.com \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maz@kernel.org \
--cc=pbonzini@redhat.com \
--cc=ricarkol@google.com \
--cc=shahuang@redhat.com \
--cc=shuah@kernel.org \
--cc=vipinsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox