* [PATCH] KVM: selftests: Remove duplicate macro definition
@ 2023-02-08 7:18 shahuang
2023-02-08 15:00 ` Sean Christopherson
0 siblings, 1 reply; 2+ messages in thread
From: shahuang @ 2023-02-08 7:18 UTC (permalink / raw)
To: kvm
Cc: Shaoqin Huang, Paolo Bonzini, Shuah Khan, Sean Christopherson,
Andrew Jones, Marc Zyngier, David Matlack, Ricardo Koller,
Ben Gardon, Vipin Sharma, open list:KERNEL SELFTEST FRAMEWORK,
open list
From: Shaoqin Huang <shahuang@redhat.com>
The KVM_GUEST_PAGE_TABLE_MIN_PADDR macro has been defined in
include/kvm_util_base.h. So remove the duplicate definition in
lib/kvm_util.c.
Signed-off-by: Shaoqin Huang <shahuang@redhat.com>
---
tools/testing/selftests/kvm/lib/kvm_util.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c
index f25b3e9b5a07..3ea24a5f4c43 100644
--- a/tools/testing/selftests/kvm/lib/kvm_util.c
+++ b/tools/testing/selftests/kvm/lib/kvm_util.c
@@ -1942,9 +1942,6 @@ vm_paddr_t vm_phy_page_alloc(struct kvm_vm *vm, vm_paddr_t paddr_min,
return vm_phy_pages_alloc(vm, 1, paddr_min, memslot);
}
-/* Arbitrary minimum physical address used for virtual translation tables. */
-#define KVM_GUEST_PAGE_TABLE_MIN_PADDR 0x180000
-
vm_paddr_t vm_alloc_page_table(struct kvm_vm *vm)
{
return vm_phy_page_alloc(vm, KVM_GUEST_PAGE_TABLE_MIN_PADDR,
--
2.39.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] KVM: selftests: Remove duplicate macro definition
2023-02-08 7:18 [PATCH] KVM: selftests: Remove duplicate macro definition shahuang
@ 2023-02-08 15:00 ` Sean Christopherson
0 siblings, 0 replies; 2+ messages in thread
From: Sean Christopherson @ 2023-02-08 15:00 UTC (permalink / raw)
To: shahuang
Cc: kvm, Paolo Bonzini, Shuah Khan, Andrew Jones, Marc Zyngier,
David Matlack, Ricardo Koller, Ben Gardon, Vipin Sharma,
open list:KERNEL SELFTEST FRAMEWORK, open list
On Wed, Feb 08, 2023, shahuang@redhat.com wrote:
> From: Shaoqin Huang <shahuang@redhat.com>
>
> The KVM_GUEST_PAGE_TABLE_MIN_PADDR macro has been defined in
> include/kvm_util_base.h. So remove the duplicate definition in
> lib/kvm_util.c.
>
> Signed-off-by: Shaoqin Huang <shahuang@redhat.com>
> ---
> tools/testing/selftests/kvm/lib/kvm_util.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c
> index f25b3e9b5a07..3ea24a5f4c43 100644
> --- a/tools/testing/selftests/kvm/lib/kvm_util.c
> +++ b/tools/testing/selftests/kvm/lib/kvm_util.c
> @@ -1942,9 +1942,6 @@ vm_paddr_t vm_phy_page_alloc(struct kvm_vm *vm, vm_paddr_t paddr_min,
> return vm_phy_pages_alloc(vm, 1, paddr_min, memslot);
> }
>
> -/* Arbitrary minimum physical address used for virtual translation tables. */
> -#define KVM_GUEST_PAGE_TABLE_MIN_PADDR 0x180000
Huh. There wasn't even a merge conflict or anything, I just added it twice in
commit cce0c23dd944 ("KVM: selftests: Add wrapper to allocate page table page").
Anyways, applied to kvm-x86 selftests with a Fixes tag. Thanks!
[1/1] KVM: selftests: Remove duplicate macro definition
https://github.com/kvm-x86/linux/commit/695fa5a64cf5
--
https://github.com/kvm-x86/linux/tree/next
https://github.com/kvm-x86/linux/tree/fixes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-08 15:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-08 7:18 [PATCH] KVM: selftests: Remove duplicate macro definition shahuang
2023-02-08 15:00 ` Sean Christopherson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox