public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: jassisinghbrar@gmail.com
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	error27@gmail.com, stern@rowland.harvard.edu,
	Jassi Brar <jaswinder.singh@linaro.org>
Subject: Re: [PATCH] usb: gadget: udc: max3420_udc: fix serialized access
Date: Wed, 8 Feb 2023 18:23:11 +0100	[thread overview]
Message-ID: <Y+PafyViJMb6OOAn@kroah.com> (raw)
In-Reply-To: <20230208163418.342210-1-jassisinghbrar@gmail.com>

On Wed, Feb 08, 2023 at 10:34:18AM -0600, jassisinghbrar@gmail.com wrote:
> From: Jassi Brar <jaswinder.singh@linaro.org>
> 
>  The mutex 'spi_bus_mutex' should be used, instead of the spin-lock,
> while changing the state of the kernel-thread.

You forgot to say why this is the case.

> Also changing the
> usb-gadget state need not be protected by a spin-lock.

Why not?  Why isn't this a separate change?

>  This should fix the Smatch static checker warning
>     warn: sleeping in atomic context
> 
> Fixes: 48ba02b2e2b1 ("usb: gadget: add udc driver for max3420")
> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
> ---
>  drivers/usb/gadget/udc/max3420_udc.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)

You forgot a "Reported-by:" line, right?

And odd indentation in your changelog text.


thanks,

greg k-h

  reply	other threads:[~2023-02-08 17:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-08 16:34 [PATCH] usb: gadget: udc: max3420_udc: fix serialized access jassisinghbrar
2023-02-08 17:23 ` Greg KH [this message]
2023-02-08 17:58   ` Jassi Brar
2023-02-08 17:23 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+PafyViJMb6OOAn@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=error27@gmail.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=jaswinder.singh@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox