From: Henrik Grimler <henrik@grimler.se>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
replicant@osuosl.org, phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
"Martin Jücker" <martin.juecker@gmail.com>
Subject: Re: [RFT PATCH 1/3] ARM: dts: exynos: add "gpios" suffix to wlf,ldo1ena on Midas
Date: Thu, 9 Feb 2023 08:14:37 +0100 [thread overview]
Message-ID: <Y+SdXZpJbm+7+SPp@L14.lan> (raw)
In-Reply-To: <20230208172634.404452-1-krzysztof.kozlowski@linaro.org>
On Wed, Feb 08, 2023 at 06:26:32PM +0100, Krzysztof Kozlowski wrote:
> The GPIOs properties should end with "gpios" suffix and Linux gpiolib
> already handles both names, so switch to preferred one.
>
> While touching the lines, replace open-coded GPIO_ACTIVE_HIGH flag.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Tested-by: Henrik Grimler <henrik@grimler.se>
Audio still works fine on i9300, and there are no new warnings/errors
in dmesg.
Best regards,
Henrik Grimler
> ---
> arch/arm/boot/dts/exynos4412-midas.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4412-midas.dtsi b/arch/arm/boot/dts/exynos4412-midas.dtsi
> index d5074fa57142..525f945c4b91 100644
> --- a/arch/arm/boot/dts/exynos4412-midas.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-midas.dtsi
> @@ -653,8 +653,8 @@ wm1811: audio-codec@1a {
> CPVDD-supply = <&vbatt_reg>;
> SPKVDD1-supply = <&vbatt_reg>;
> SPKVDD2-supply = <&vbatt_reg>;
> - wlf,ldo1ena = <&gpj0 4 0>;
> - wlf,ldo2ena = <&gpj0 4 0>;
> + wlf,ldo1ena-gpios = <&gpj0 4 GPIO_ACTIVE_HIGH>;
> + wlf,ldo2ena-gpios = <&gpj0 4 GPIO_ACTIVE_HIGH>;
> };
> };
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-02-09 7:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 17:26 [RFT PATCH 1/3] ARM: dts: exynos: add "gpios" suffix to wlf,ldo1ena on Midas Krzysztof Kozlowski
2023-02-08 17:26 ` [RFT PATCH 2/3] ARM: dts: exynos: add "gpios" suffix to wlf,ldo1ena on Arndale Krzysztof Kozlowski
2023-02-08 17:26 ` [RFT PATCH 3/3] ARM: dts: s5pv210: add "gpios" suffix to wlf,ldo1ena on Aries Krzysztof Kozlowski
2023-02-09 7:14 ` Henrik Grimler [this message]
2023-02-09 11:10 ` [RFT PATCH 1/3] ARM: dts: exynos: add "gpios" suffix to wlf,ldo1ena on Midas Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+SdXZpJbm+7+SPp@L14.lan \
--to=henrik@grimler.se \
--cc=alim.akhtar@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=martin.juecker@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=replicant@osuosl.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox