From: Simon Horman <simon.horman@corigine.com>
To: Eelco Chaudron <echaudro@redhat.com>
Cc: Hangyu Hua <hbh25y@gmail.com>,
pshelar@ovn.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, xiangxia.m.yue@gmail.com,
netdev@vger.kernel.org, dev@openvswitch.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] net: openvswitch: fix possible memory leak in ovs_meter_cmd_set()
Date: Fri, 10 Feb 2023 09:49:49 +0100 [thread overview]
Message-ID: <Y+YFLccEN8Gr0nZE@corigine.com> (raw)
In-Reply-To: <6582F9D7-D74B-4A4A-A498-1B3002B9840E@redhat.com>
On Fri, Feb 10, 2023 at 08:35:50AM +0100, Eelco Chaudron wrote:
>
>
> On 10 Feb 2023, at 3:05, Hangyu Hua wrote:
>
> > old_meter needs to be free after it is detached regardless of whether
> > the new meter is successfully attached.
> >
> > Fixes: c7c4c44c9a95 ("net: openvswitch: expand the meters supported number")
> > Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
>
> Thanks for doing a v3. The change looks good to me!
>
> Acked-by: Eelco Chaudron <echaudro@redhat.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-02-10 8:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 2:05 [PATCH v3] net: openvswitch: fix possible memory leak in ovs_meter_cmd_set() Hangyu Hua
2023-02-10 7:35 ` Eelco Chaudron
2023-02-10 8:49 ` Simon Horman [this message]
2023-02-13 9:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+YFLccEN8Gr0nZE@corigine.com \
--to=simon.horman@corigine.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=edumazet@google.com \
--cc=hbh25y@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pshelar@ovn.org \
--cc=xiangxia.m.yue@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox