public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next] net: pcs: rzn1-miic: remove unused struct members and use miic variable
@ 2023-02-08 16:12 Clément Léger
  2023-02-10  6:50 ` patchwork-bot+netdevbpf
  2023-02-10 11:05 ` Russell King (Oracle)
  0 siblings, 2 replies; 3+ messages in thread
From: Clément Léger @ 2023-02-08 16:12 UTC (permalink / raw)
  To: Andrew Lunn, Heiner Kallweit, Russell King, David S. Miller,
	Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: Clément Léger, linux-renesas-soc, netdev, linux-kernel

Remove unused bulk clocks struct from the miic state and use an already
existing miic variable in miic_config().

Signed-off-by: Clément Léger <clement.leger@bootlin.com>
---
 drivers/net/pcs/pcs-rzn1-miic.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/net/pcs/pcs-rzn1-miic.c b/drivers/net/pcs/pcs-rzn1-miic.c
index c1424119e821..323bec5e57f8 100644
--- a/drivers/net/pcs/pcs-rzn1-miic.c
+++ b/drivers/net/pcs/pcs-rzn1-miic.c
@@ -121,15 +121,11 @@ static const char *index_to_string[MIIC_MODCTRL_CONF_CONV_NUM] = {
  * struct miic - MII converter structure
  * @base: base address of the MII converter
  * @dev: Device associated to the MII converter
- * @clks: Clocks used for this device
- * @nclk: Number of clocks
  * @lock: Lock used for read-modify-write access
  */
 struct miic {
 	void __iomem *base;
 	struct device *dev;
-	struct clk_bulk_data *clks;
-	int nclk;
 	spinlock_t lock;
 };
 
@@ -232,7 +228,7 @@ static int miic_config(struct phylink_pcs *pcs, unsigned int mode,
 	}
 
 	miic_reg_rmw(miic, MIIC_CONVCTRL(port), mask, val);
-	miic_converter_enable(miic_port->miic, miic_port->port, 1);
+	miic_converter_enable(miic, miic_port->port, 1);
 
 	return 0;
 }
-- 
2.39.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: pcs: rzn1-miic: remove unused struct members and use miic variable
  2023-02-08 16:12 [PATCH net-next] net: pcs: rzn1-miic: remove unused struct members and use miic variable Clément Léger
@ 2023-02-10  6:50 ` patchwork-bot+netdevbpf
  2023-02-10 11:05 ` Russell King (Oracle)
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-02-10  6:50 UTC (permalink / raw)
  To: =?utf-8?b?Q2zDqW1lbnQgTMOpZ2VyIDxjbGVtZW50LmxlZ2VyQGJvb3RsaW4uY29tPg==?=
  Cc: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni,
	linux-renesas-soc, netdev, linux-kernel

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Wed,  8 Feb 2023 17:12:49 +0100 you wrote:
> Remove unused bulk clocks struct from the miic state and use an already
> existing miic variable in miic_config().
> 
> Signed-off-by: Clément Léger <clement.leger@bootlin.com>
> ---
>  drivers/net/pcs/pcs-rzn1-miic.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)

Here is the summary with links:
  - [net-next] net: pcs: rzn1-miic: remove unused struct members and use miic variable
    https://git.kernel.org/netdev/net-next/c/dc8c41320130

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: pcs: rzn1-miic: remove unused struct members and use miic variable
  2023-02-08 16:12 [PATCH net-next] net: pcs: rzn1-miic: remove unused struct members and use miic variable Clément Léger
  2023-02-10  6:50 ` patchwork-bot+netdevbpf
@ 2023-02-10 11:05 ` Russell King (Oracle)
  1 sibling, 0 replies; 3+ messages in thread
From: Russell King (Oracle) @ 2023-02-10 11:05 UTC (permalink / raw)
  To: Clément Léger
  Cc: Andrew Lunn, Heiner Kallweit, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, linux-renesas-soc, netdev,
	linux-kernel

On Wed, Feb 08, 2023 at 05:12:49PM +0100, Clément Léger wrote:
> Remove unused bulk clocks struct from the miic state and use an already
> existing miic variable in miic_config().
> 
> Signed-off-by: Clément Léger <clement.leger@bootlin.com>

Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-02-10 11:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-08 16:12 [PATCH net-next] net: pcs: rzn1-miic: remove unused struct members and use miic variable Clément Léger
2023-02-10  6:50 ` patchwork-bot+netdevbpf
2023-02-10 11:05 ` Russell King (Oracle)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox