From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Werner Sembach <wse@tuxedocomputers.com>
Cc: mika.westerberg@linux.intel.com, linus.walleij@linaro.org,
brgl@bgdev.pl, linux-gpio@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpiolib: acpi: Add a ignore wakeup quirk for Clevo NH5xAx
Date: Fri, 10 Feb 2023 19:04:57 +0200 [thread overview]
Message-ID: <Y+Z5OSa6hepQBOyc@smile.fi.intel.com> (raw)
In-Reply-To: <20230210164636.628462-1-wse@tuxedocomputers.com>
On Fri, Feb 10, 2023 at 05:46:36PM +0100, Werner Sembach wrote:
> commit 1796f808e4bb ("HID: i2c-hid: acpi: Stop setting wakeup_capable")
> changed the policy such that I2C touchpads may be able to wake up the
> system by default if the system is configured as such.
>
> However on Clevo NH5xAx/TUXEDO XA15 Gen10 there is a mistake in the ACPI
> tables that the TP_ATTN# signal connected to GPIO 10 is configured as
> ActiveLow and level triggered but connected to a pull up.
I'm not sure I understand the issue here. From what you say here it seems
correct ACPI description.
> As soon as the
> system suspends the touchpad loses power and then the system wakes up.
>
> To avoid this problem, introduce a quirk for this model that will prevent
> the wakeup capability for being set for GPIO 10.
I'm not against fixing this, but wouldn't be better to actually target the root
cause and have a different quirk? Or is it me who didn't get what is the root
cause?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-02-10 17:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 16:46 [PATCH] gpiolib: acpi: Add a ignore wakeup quirk for Clevo NH5xAx Werner Sembach
2023-02-10 17:04 ` Andy Shevchenko [this message]
2023-02-13 11:30 ` Werner Sembach
2023-02-13 12:41 ` Andy Shevchenko
2023-02-13 13:20 ` Mario Limonciello
2023-02-13 14:37 ` Andy Shevchenko
2023-02-13 14:47 ` Werner Sembach
2023-02-13 17:20 ` Raul Rangel
2023-02-13 17:50 ` Andy Shevchenko
2023-02-13 17:57 ` Andy Shevchenko
2023-02-13 17:59 ` Andy Shevchenko
2023-02-13 18:01 ` Andy Shevchenko
2023-02-13 18:20 ` Raul Rangel
2023-02-13 19:00 ` Andy Shevchenko
2023-02-13 21:56 ` andy.shevchenko
2023-02-14 12:31 ` Werner Sembach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+Z5OSa6hepQBOyc@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wse@tuxedocomputers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox