From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E790BC636D4 for ; Sat, 11 Feb 2023 18:47:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229635AbjBKSrJ (ORCPT ); Sat, 11 Feb 2023 13:47:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229622AbjBKSrI (ORCPT ); Sat, 11 Feb 2023 13:47:08 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 963F51206B for ; Sat, 11 Feb 2023 10:47:06 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id r2so8317220wrv.7 for ; Sat, 11 Feb 2023 10:47:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KNBad6NsbeeE2FNcNuGKb8u8bOm8xtWArbSi+T9+PoY=; b=nuiF2WwY/92TbEXExLUCBjho7sx8HcuyGc26XDvv+ZPg87LLyxEM2LpncPSQbe6GuP 9W1jbIwUFxjtMCVUKdZOvUyFILOdfHsLgYkSVUyPaAig/73zfNeouzs6pTl0t3zHhcp0 WcPtz2r1CuZsl2ezTPOORwf3wrjegVbJrMBlk5qTUG+E++6FFDYVq13tvCKAw1HuLGda 1K6wVokxA7u6oqlaWvpVuP43M4x8g2yDHMLTOnO4o7/RBy67r/VBml3IrODbtd6rRnuI 8wkRyYb61vPNZmVY1/9QkUaLKoWHKU+gUGRmnY1YgQTJS8C6a6SXBtc7cai8ERbC1VLO bkVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KNBad6NsbeeE2FNcNuGKb8u8bOm8xtWArbSi+T9+PoY=; b=VIRgwrk0pbT/x2VY/1qUaMvqRDkc5hpwYT//awZBBpu7mbFZaJRuHL0da1srIdLsY0 evvsxicBLHamxjGZtrS2e2ZGIzDmRYq7HLxoz7MYmWZB43ag27zhBe9E1lQKdhROzq3u cXD1bam3IWgOe2mo9k0XwMgSoj+Q+Pb4ZGSgUu6SzPXW4NCjJ1udoUlw/zpy2bwTOl+x TiVanHllGIjUKiwX8bnUX7LW3mtMgfm4lT+X722KxpSjqJlHZrS/66vgl5NCFx5ogS2H juNMTpDxGkuHcLqHEspxNeX79VnYdOPj0PtWIUug7+HbJtMxG5UaTTDZOtfL/38fjIPq u7Lw== X-Gm-Message-State: AO0yUKWxmxNArX0ziRPmfc3rBEPHvFLIbj1dZn2iwNiDjm7Joizk9RhD YXR964soMRRqMYNEK1Xy6n4HRw== X-Google-Smtp-Source: AK7set9s7CRYhJPbImN7bcy2NZQuDzbh8phSbwqhfSA5Uez3aqqIQKRtoaDSNcfw0Q0sRUJX63f7vQ== X-Received: by 2002:a5d:67c8:0:b0:2bf:dfa3:2e78 with SMTP id n8-20020a5d67c8000000b002bfdfa32e78mr17201185wrw.64.1676141225101; Sat, 11 Feb 2023 10:47:05 -0800 (PST) Received: from linaro.org ([94.52.112.99]) by smtp.gmail.com with ESMTPSA id f18-20020adff992000000b002c5544b3a69sm5982wrr.89.2023.02.11.10.47.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Feb 2023 10:47:04 -0800 (PST) Date: Sat, 11 Feb 2023 20:47:03 +0200 From: Abel Vesa To: Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Neil Armstrong Subject: Re: [PATCH] regulator: dt-bindings: qcom,rpmh: Correct PM8550 family supplies Message-ID: References: <20230210155930.549082-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230210155930.549082-1-krzysztof.kozlowski@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23-02-10 16:59:30, Krzysztof Kozlowski wrote: > PM8550 is different than PM8550VE/VS, because the latter has much > smaller amount of supplies (l1-3 and s1-6) and regulators. The PM8550 > has on theh other hand one pin for vdd-l1-l4-l10 supplies. Correct the Nit: ... on the other ... > if:then: clause with their supplies. > > Signed-off-by: Krzysztof Kozlowski Otherwise, LGTM: Reviewed-by: Abel Vesa > --- > .../bindings/regulator/qcom,rpmh-regulator.yaml | 16 +++++++++++++--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml > index 297a75069f60..fb9621b4b4cd 100644 > --- a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml > +++ b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml > @@ -308,19 +308,29 @@ allOf: > compatible: > enum: > - qcom,pm8550-rpmh-regulators > - - qcom,pm8550ve-rpmh-regulators > - - qcom,pm8550vs-rpmh-regulators > then: > properties: > + vdd-l1-l4-l10-supply: true > vdd-l2-l13-l14-supply: true > vdd-l5-l16-supply: true > vdd-l6-l7-supply: true > vdd-l8-l9-supply: true > patternProperties: > - "^vdd-l([1-4]|1[0-7])-supply$": true > + "^vdd-l(3|1[1-7])-supply$": true > "^vdd-s[1-6]-supply$": true > "^vdd-bob[1-2]-supply$": true > > + - if: > + properties: > + compatible: > + enum: > + - qcom,pm8550ve-rpmh-regulators > + - qcom,pm8550vs-rpmh-regulators > + then: > + patternProperties: > + "^vdd-l[1-3]-supply$": true > + "^vdd-s[1-6]-supply$": true > + > - if: > properties: > compatible: > -- > 2.34.1 >