* [PATCH] regulator: dt-bindings: qcom,rpmh: Correct PM8550 family supplies
@ 2023-02-10 15:59 Krzysztof Kozlowski
2023-02-11 18:47 ` Abel Vesa
2023-02-14 23:47 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-10 15:59 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Liam Girdwood,
Mark Brown, Rob Herring, Krzysztof Kozlowski, linux-arm-msm,
linux-kernel, devicetree
Cc: Abel Vesa, Neil Armstrong, Krzysztof Kozlowski
PM8550 is different than PM8550VE/VS, because the latter has much
smaller amount of supplies (l1-3 and s1-6) and regulators. The PM8550
has on theh other hand one pin for vdd-l1-l4-l10 supplies. Correct the
if:then: clause with their supplies.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/regulator/qcom,rpmh-regulator.yaml | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
index 297a75069f60..fb9621b4b4cd 100644
--- a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
@@ -308,19 +308,29 @@ allOf:
compatible:
enum:
- qcom,pm8550-rpmh-regulators
- - qcom,pm8550ve-rpmh-regulators
- - qcom,pm8550vs-rpmh-regulators
then:
properties:
+ vdd-l1-l4-l10-supply: true
vdd-l2-l13-l14-supply: true
vdd-l5-l16-supply: true
vdd-l6-l7-supply: true
vdd-l8-l9-supply: true
patternProperties:
- "^vdd-l([1-4]|1[0-7])-supply$": true
+ "^vdd-l(3|1[1-7])-supply$": true
"^vdd-s[1-6]-supply$": true
"^vdd-bob[1-2]-supply$": true
+ - if:
+ properties:
+ compatible:
+ enum:
+ - qcom,pm8550ve-rpmh-regulators
+ - qcom,pm8550vs-rpmh-regulators
+ then:
+ patternProperties:
+ "^vdd-l[1-3]-supply$": true
+ "^vdd-s[1-6]-supply$": true
+
- if:
properties:
compatible:
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] regulator: dt-bindings: qcom,rpmh: Correct PM8550 family supplies
2023-02-10 15:59 [PATCH] regulator: dt-bindings: qcom,rpmh: Correct PM8550 family supplies Krzysztof Kozlowski
@ 2023-02-11 18:47 ` Abel Vesa
2023-02-14 23:47 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Abel Vesa @ 2023-02-11 18:47 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Liam Girdwood,
Mark Brown, Rob Herring, Krzysztof Kozlowski, linux-arm-msm,
linux-kernel, devicetree, Neil Armstrong
On 23-02-10 16:59:30, Krzysztof Kozlowski wrote:
> PM8550 is different than PM8550VE/VS, because the latter has much
> smaller amount of supplies (l1-3 and s1-6) and regulators. The PM8550
> has on theh other hand one pin for vdd-l1-l4-l10 supplies. Correct the
Nit: ... on the other ...
> if:then: clause with their supplies.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Otherwise, LGTM:
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> .../bindings/regulator/qcom,rpmh-regulator.yaml | 16 +++++++++++++---
> 1 file changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
> index 297a75069f60..fb9621b4b4cd 100644
> --- a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
> @@ -308,19 +308,29 @@ allOf:
> compatible:
> enum:
> - qcom,pm8550-rpmh-regulators
> - - qcom,pm8550ve-rpmh-regulators
> - - qcom,pm8550vs-rpmh-regulators
> then:
> properties:
> + vdd-l1-l4-l10-supply: true
> vdd-l2-l13-l14-supply: true
> vdd-l5-l16-supply: true
> vdd-l6-l7-supply: true
> vdd-l8-l9-supply: true
> patternProperties:
> - "^vdd-l([1-4]|1[0-7])-supply$": true
> + "^vdd-l(3|1[1-7])-supply$": true
> "^vdd-s[1-6]-supply$": true
> "^vdd-bob[1-2]-supply$": true
>
> + - if:
> + properties:
> + compatible:
> + enum:
> + - qcom,pm8550ve-rpmh-regulators
> + - qcom,pm8550vs-rpmh-regulators
> + then:
> + patternProperties:
> + "^vdd-l[1-3]-supply$": true
> + "^vdd-s[1-6]-supply$": true
> +
> - if:
> properties:
> compatible:
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: dt-bindings: qcom,rpmh: Correct PM8550 family supplies
2023-02-10 15:59 [PATCH] regulator: dt-bindings: qcom,rpmh: Correct PM8550 family supplies Krzysztof Kozlowski
2023-02-11 18:47 ` Abel Vesa
@ 2023-02-14 23:47 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2023-02-14 23:47 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Liam Girdwood, linux-kernel, linux-arm-msm, Mark Brown,
Rob Herring, Neil Armstrong, devicetree, Bjorn Andersson,
Konrad Dybcio, Krzysztof Kozlowski, Abel Vesa, Andy Gross
On Fri, 10 Feb 2023 16:59:30 +0100, Krzysztof Kozlowski wrote:
> PM8550 is different than PM8550VE/VS, because the latter has much
> smaller amount of supplies (l1-3 and s1-6) and regulators. The PM8550
> has on theh other hand one pin for vdd-l1-l4-l10 supplies. Correct the
> if:then: clause with their supplies.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/regulator/qcom,rpmh-regulator.yaml | 16 +++++++++++++---
> 1 file changed, 13 insertions(+), 3 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-14 23:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-10 15:59 [PATCH] regulator: dt-bindings: qcom,rpmh: Correct PM8550 family supplies Krzysztof Kozlowski
2023-02-11 18:47 ` Abel Vesa
2023-02-14 23:47 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox