Re: [PATCH v2] docs/mm: Physical Memory: add example of interleaving nodes

Mike Rapoport
2023-02-12T14:48:07Z

On Sun, Feb 12, 2023 at 11:50:08AM +0000, Matthew Wilcox wrote:
> On Sun, Feb 12, 2023 at 11:54:45AM +0200, Mike Rapoport wrote:
> > +Note, that memory banks may belong to interleaving nodes. In the example
> > +below an x86 machine has 16Gbytes or RAM in 4 memory banks, even banks
> > +belong to node 0 and odd banks belong to node 1::
>
> s/or RAM/of RAM/

Thanks

> The "Note," is superfluous, you can just write:
>
> Memory banks may belong to interleaved nodes.

Ok

> And I think we prefer the newer form "GiB" for new documentation.

I've used Gbytes in previous examples, so I'd prefer to keep it consistent
We can swipe s/Gbytes/GiB/g later.

> > +
> > + 0 4G 8G 12G 16G
> > + +-------------+ +-------------+ +-------------+ +-------------+
> > + | node 0 | | node 1 | | node 0 | | node 1 |
> > + +-------------+ +-------------+ +-------------+ +-------------+
> > +
> > + 0 16M 4G
> > + +-----+-------+ +-------------+ +-------------+ +-------------+
> > + | DMA | DMA32 | | NORMAL | | NORMAL | | NORMAL |
> > + +-----+-------+ +-------------+ +-------------+ +-------------+
> > +
> > +In such case node 0 will span from 0 to 12 Gbytes and node 1 will span from
> > +4 to 16 Gbytes.
>
> s/such/this/ (and I'd use GiB again)

--
Sincerely yours,
Mike.