From: Alain Volmat <avolmat@me.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Patrice Chotard <patrice.chotard@foss.st.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: arm: sti: add sti boards and remove stih415/stih416
Date: Sun, 12 Feb 2023 21:16:08 +0100 [thread overview]
Message-ID: <Y+lJCBqSAIJ01MT+@imac101> (raw)
In-Reply-To: <35ac595b-a451-870c-6e1c-613d1e817591@linaro.org>
Thanks for the review
On Sun, Feb 12, 2023 at 05:02:17PM +0100, Krzysztof Kozlowski wrote:
> On 11/02/2023 22:04, Alain Volmat wrote:
> > Add bindings for STi platform boards and remove stih415/stih416 items.
> > This commit also moves the sti.yaml binding file within the arm/sti/
> > folder instead of arm/
> >
> > Signed-off-by: Alain Volmat <avolmat@me.com>
> > ---
> > .../devicetree/bindings/arm/sti.yaml | 26 ---------------
> > .../devicetree/bindings/arm/sti/sti.yaml | 33 +++++++++++++++++++
> > 2 files changed, 33 insertions(+), 26 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/arm/sti.yaml
> > create mode 100644 Documentation/devicetree/bindings/arm/sti/sti.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/arm/sti.yaml b/Documentation/devicetree/bindings/arm/sti.yaml
> > deleted file mode 100644
> > index 3ca054c64377..000000000000
> > --- a/Documentation/devicetree/bindings/arm/sti.yaml
> > +++ /dev/null
> > @@ -1,26 +0,0 @@
> > -# SPDX-License-Identifier: GPL-2.0
> > -%YAML 1.2
> > ----
> > -$id: http://devicetree.org/schemas/arm/sti.yaml#
> > -$schema: http://devicetree.org/meta-schemas/core.yaml#
> > -
> > -title: ST STi Platforms
> > -
> > -maintainers:
> > - - Patrice Chotard <patrice.chotard@foss.st.com>
> > -
> > -properties:
> > - $nodename:
> > - const: '/'
> > - compatible:
> > - items:
> > - - enum:
> > - - st,stih415
> > - - st,stih416
> > - - st,stih407
> > - - st,stih410
> > - - st,stih418
> > -
> > -additionalProperties: true
> > -
> > -...
> > diff --git a/Documentation/devicetree/bindings/arm/sti/sti.yaml b/Documentation/devicetree/bindings/arm/sti/sti.yaml
> > new file mode 100644
> > index 000000000000..aefa1919207c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/arm/sti/sti.yaml
> > @@ -0,0 +1,33 @@
> > +# SPDX-License-Identifier: GPL-2.0
>
> Dual-license. I don't think there is anything from old binding being
> copied here (you can as well start from scratch from other binding and
> result will be the same).
Ok
I understand, based on your review of the other patch in the serie that
I should put this sti.yaml within bindings/soc/sti right ?
Moreover, I made a mistake and removed st,stih415 and st,stih416 in
this patch while I already posted the patch in the STiH415/STiH416
removal serie (https://lore.kernel.org/all/20230209091659.1409-6-avolmat@me.com/).
I propose to get rid of the patch in the other serie and do the removal
within this patch since it also moves the file.
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-02-12 20:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-11 21:04 [PATCH 1/2] dt-bindings: arm: sti: addition of STi platform syscon Alain Volmat
2023-02-11 21:04 ` [PATCH 2/2] dt-bindings: arm: sti: add sti boards and remove stih415/stih416 Alain Volmat
2023-02-12 16:02 ` Krzysztof Kozlowski
2023-02-12 20:16 ` Alain Volmat [this message]
2023-02-12 16:00 ` [PATCH 1/2] dt-bindings: arm: sti: addition of STi platform syscon Krzysztof Kozlowski
2023-02-12 20:09 ` Alain Volmat
2023-02-12 16:01 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+lJCBqSAIJ01MT+@imac101 \
--to=avolmat@me.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrice.chotard@foss.st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox