Re: [PATCH 2/2] iommu/ioasid: Remove custom IOASID allocator

Jean-Philippe Brucker
2023-02-13T16:20:45Z

On Fri, Feb 10, 2023 at 03:02:06PM -0800, Jacob Pan wrote:
> Custom allocator feature was introduced to support VT-d's virtual
> command, an enlightened interface designed for VMs to allocate PASIDs
> from the host.
>
> As we remove/withdraw the VT-d virtual command feature, the sole user
> of custom allocator, we can safely remove the custom allocator as well.
> Effectively, this will return IOASID core to the original simple global
> namespace allocator.
>
> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>

You can also drop the spinlock.h include. With that:

Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>

On a related note, it looks like 100b8a14a370 ("iommu/vt-d: Add pasid
private data helpers") removed the last user of ioasid_set_data(). I guess
that could be dropped too, unless you plan to still use it?

We could also merge ioasid.c into iommu-sva.c at this point, since I
haven't seen any interest for having multiple IOASID sets on Arm, but I'm
not sure what the current plan is for vSVA on x86.

Thanks,
Jean