From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Carlos Llamas <cmllamas@google.com>
Cc: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Jialu Xu <xujialu@vimux.org>,
linux-kernel@vger.kernel.org
Subject: Re: libpcre2 breaks COMPILED_SOURCE=1 tags
Date: Tue, 14 Feb 2023 07:17:10 +0100 [thread overview]
Message-ID: <Y+snZioVyo82mAUj@kroah.com> (raw)
In-Reply-To: <Y+qYdA7OpRX16Lwf@google.com>
On Mon, Feb 13, 2023 at 08:07:16PM +0000, Carlos Llamas wrote:
> Newer versions of libpre2 have dropped default support for \K in
> lookarounds. Unfortunately, scripts/tags.sh relies on this option to
> collect all the _compiled_ sources. This is the error:
>
> $ make COMPILED_SOURCE=1 tags
> GEN tags
> grep: \K is not allowed in lookarounds (but see PCRE2_EXTRA_ALLOW_LOOKAROUND_BSK)
>
> It seems there isn't an official maintainer for this script and I can't
> quite understand the regex used for the query. Does anyone have a good
> alternative for this? The regex pattern was introduced in commit
> 4f491bb6ea2a ("scripts/tags.sh: collect compiled source precisely").
>
> The previous form of all_compiled_sources() seems to work for me and I'm
> guessing it wasn't efficient enough? I can't find much info about the
> switch to find/grep either. I believe the initial thread is this:
> https://lore.kernel.org/all/20200423103801.GA3730892@kroah.com/
Can you send a patch to revert the offending change? That would be the
simplest for now, right?
thanks,
greg k-h
next prev parent reply other threads:[~2023-02-14 6:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 20:07 libpcre2 breaks COMPILED_SOURCE=1 tags Carlos Llamas
2023-02-14 6:17 ` Greg Kroah-Hartman [this message]
2023-02-14 20:41 ` [PATCH] scripts/tags.sh: fix incompatibility with PCRE2 Carlos Llamas
2023-02-15 16:48 ` Greg Kroah-Hartman
2023-02-15 17:28 ` Carlos Llamas
2023-02-15 18:38 ` [PATCH v2] " Carlos Llamas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+snZioVyo82mAUj@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=cmllamas@google.com \
--cc=cristian.ciocaltea@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=xujialu@vimux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox