From: andy.shevchenko@gmail.com
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] gpio: vf610: make irq_chip immutable
Date: Tue, 14 Feb 2023 12:52:13 +0200 [thread overview]
Message-ID: <Y+tn3Y+SraIetn5X@surfacebook> (raw)
In-Reply-To: <20230214073638.571417-1-alexander.stein@ew.tq-group.com>
Tue, Feb 14, 2023 at 08:36:38AM +0100, Alexander Stein kirjoitti:
> Since recently, the kernel is nagging about mutable irq_chips:
>
> "not an immutable chip, please consider fixing it!"
>
> Drop the unneeded copy, flag it as IRQCHIP_IMMUTABLE, add the new
> helper functions and call the appropriate gpiolib functions.
...
> The overall changes are based on commit f1138dacb7ff
> ("gpio: sch: make irq_chip immutable")
Nice, but you forgot one crucial detail. You need to mark GPIO resuested
whenever it's locked as IRQ and otherwise when unlocked.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-02-14 10:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 7:36 [PATCH 1/1] gpio: vf610: make irq_chip immutable Alexander Stein
2023-02-14 10:52 ` andy.shevchenko [this message]
2023-02-15 10:18 ` Linus Walleij
2023-02-15 11:09 ` Alexander Stein
2023-02-15 11:19 ` Linus Walleij
2023-02-15 11:51 ` Andy Shevchenko
2023-02-15 10:19 ` Linus Walleij
2023-02-15 11:16 ` Marc Zyngier
2023-02-15 11:33 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+tn3Y+SraIetn5X@surfacebook \
--to=andy.shevchenko@gmail.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox