public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-rdma@vger.kernel.org
Subject: Re: [PATCH] RDMA/restrack: Reorder fields in 'struct rdma_restrack_entry'
Date: Wed, 15 Feb 2023 13:31:31 +0200	[thread overview]
Message-ID: <Y+zCkwTgevj0zDFK@unreal> (raw)
In-Reply-To: <Y+uiLCB7H2xVvQZW@ziepe.ca>

On Tue, Feb 14, 2023 at 11:01:00AM -0400, Jason Gunthorpe wrote:
> On Tue, Feb 14, 2023 at 03:34:21PM +0100, Christophe JAILLET wrote:
> > Le 14/02/2023 à 14:08, Jason Gunthorpe a écrit :
> > > On Tue, Feb 14, 2023 at 01:53:52PM +0100, Christophe JAILLET wrote:
> > > > diff --git a/include/rdma/restrack.h b/include/rdma/restrack.h
> > > > index 8b7c46daeb07..da53fefe6f9e 100644
> > > > --- a/include/rdma/restrack.h
> > > > +++ b/include/rdma/restrack.h
> > > > @@ -80,6 +80,10 @@ struct rdma_restrack_entry {
> > > >   	 * query stage.
> > > >   	 */
> > > >   	u8			no_track : 1;
> > > > +	/**
> > > > +	 * @user: user resource
> > > > +	 */
> > > > +	bool			user;
> > > 
> > > Can we combine this into the bitfield above?
> > > 
> > > Jason
> > > 
> > Hi,
> > 
> > and even above, we have
> > 	bool	valid;
> > 
> > I wanted to keep the changes as minimal as possible, but I can change them
> > all in a single bitfield.
> 
> IIRC it needs to be checked, I vaugely remember valid can't be a
> bitfield because it is an atomic

I don't remember anything like this.

Thanks

  reply	other threads:[~2023-02-15 11:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-14 12:53 [PATCH] RDMA/restrack: Reorder fields in 'struct rdma_restrack_entry' Christophe JAILLET
2023-02-14 13:08 ` Jason Gunthorpe
2023-02-14 14:34   ` Christophe JAILLET
2023-02-14 15:01     ` Jason Gunthorpe
2023-02-15 11:31       ` Leon Romanovsky [this message]
2023-02-20 22:16         ` Christophe JAILLET

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+zCkwTgevj0zDFK@unreal \
    --to=leon@kernel.org \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=jgg@ziepe.ca \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox