Re: [PATCH] null_blk: allow teardown on request timeout

[Ming Lei <ming.lei@redhat.com>]

On Mon, Oct 17, 2022 at 09:30:47AM +0000, Chaitanya Kulkarni wrote:
> 
> >> +	/*
> >> +	 * Unblock any pending dispatch I/Os before we destroy the device.
> >> +	 * From null_destroy_dev()->del_gendisk() will set GD_DEAD flag
> >> +	 * causing any new I/O from __bio_queue_enter() to fail with -ENODEV.
> >> +	 */
> >> +	blk_mq_unquiesce_queue(nullb->q);
> >> +
> >> +	null_destroy_dev(nullb);
> > 
> > destroying device is never good cleanup for handling timeout/abort, and it
> > should have been the last straw any time.
> > 
> 
> That is exactly why I've added the rq_abort_limit, so until the limit
> is not reached null_abort_work() will not get scheduled and device is
> not destroyed.

I meant destroying device should only be done iff the normal abort handler
can't recover the device, however, your patch simply destroys device
without running any abort handling.


Thanks,
Ming