From: Alyssa Rosenzweig <alyssa@collabora.com>
To: Steven Price <steven.price@arm.com>
Cc: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
Adri??n Larumbe <adrian.larumbe@collabora.com>,
Rob Herring <robh@kernel.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH v2 0/2] drm/panfrost: Fix UAPI for C++/BSD compatibility
Date: Mon, 17 Oct 2022 11:44:22 -0400 [thread overview]
Message-ID: <Y014Vh1hGahjqUlB@maud> (raw)
In-Reply-To: <20221017104602.142992-1-steven.price@arm.com>
Series is
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Thank you for this, please push to the appropriate trees so we can fix
the Mesa build.
On Mon, Oct 17, 2022 at 11:46:00AM +0100, Steven Price wrote:
> The Panfrost DRM interface to user space is uesd in Mesa for targets
> other than C/Linux. Specifically the header file needs to compile in C++
> code and for FreeBSD which shares the same UABI.
>
> The first patch fixes the C++ compilation issue by removing the
> (unnecessary) type name from internal structs which is invalid in C++.
>
> The second patch technically changes the UABI by changing the header
> values in the dump format to be native endian rather than fixed
> little-endian. Since (a) there are no known big-endian Mali systems, and
> (b) this has only appeared in -rc1, this shouldn't break user space.
> Tools can use the 'magic' field to identify the endianness of the dump
> if they want to support big-endian.
>
> This is effectively a 'v2' of Adri??n's series here [1].
>
> [1] https://lore.kernel.org/r/20220920211545.1017355-1-adrian.larumbe%40collabora.com
>
> Steven Price (2):
> drm/panfrost: Remove type name from internal structs
> drm/panfrost: replace endian-specific types with native ones
>
> drivers/gpu/drm/panfrost/panfrost_dump.c | 36 ++++++++++++------------
> include/uapi/drm/panfrost_drm.h | 36 +++++++++++++-----------
> 2 files changed, 38 insertions(+), 34 deletions(-)
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2022-10-17 15:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 10:46 [PATCH v2 0/2] drm/panfrost: Fix UAPI for C++/BSD compatibility Steven Price
2022-10-17 10:46 ` [PATCH v2 1/2] drm/panfrost: Remove type name from internal structs Steven Price
2022-10-17 10:46 ` [PATCH v2 2/2] drm/panfrost: replace endian-specific types with native ones Steven Price
2022-10-17 15:44 ` Alyssa Rosenzweig [this message]
2022-10-20 10:17 ` [PATCH v2 0/2] drm/panfrost: Fix UAPI for C++/BSD compatibility Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y014Vh1hGahjqUlB@maud \
--to=alyssa@collabora.com \
--cc=adrian.larumbe@collabora.com \
--cc=alyssa.rosenzweig@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=steven.price@arm.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox