From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2902EC433FE for ; Mon, 17 Oct 2022 18:21:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229782AbiJQSVD (ORCPT ); Mon, 17 Oct 2022 14:21:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229921AbiJQSU7 (ORCPT ); Mon, 17 Oct 2022 14:20:59 -0400 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B43C06D9E9 for ; Mon, 17 Oct 2022 11:20:57 -0700 (PDT) Received: by mail-qk1-x730.google.com with SMTP id t25so7188888qkm.2 for ; Mon, 17 Oct 2022 11:20:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0ASJnvbXdmbENnmELYX21Km/XI3pCAL3HYWqBCGT72Y=; b=py5hnISP+vNcRCvrzlR6VM021OOidZOopS8YOp2I/MYSkjn/IXbXq0MP760tCiZIeq vhIF88sffbaI+QdDO9hXnsYiLNdQxr6FM26NE9RI9fTeivzUL6c9JzGZRWa9vsihF9Yw 83YT6UGOE+sWnm+cGaWoaY+t4C1LG7cAhD89p0aMTwfru10b9bUWNUqzrvPIq2zfXtve 1Rsu2RgKer9QZavQfj+9tBWtkiwI5XzORJ+z9ZIOrfb/KrVyuHUFmTpfqpw0i57nDRhl 7xDiqRzZ1M9LmFgZltEn9XDDX/t8sJvwZ/9FS/cIXqw5nbJe4M4B8Zm55xIwBJ8wb1i3 n4Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0ASJnvbXdmbENnmELYX21Km/XI3pCAL3HYWqBCGT72Y=; b=1nZM1rvnT8fiSfpXC3Vkj08XYl2IeeLnP+we+0UCRz5D68wP/NCbzNvxohWQsspuZP 2K99JWoPlasd09uQ69uVbjzohosAUhI8ZIdNG+jmu01Ty+SH5uMVL8wEoypVN5Ao+0sZ yW9LeOvmiE6mAHaviKiXMDaN8iHSqLUB9fXtWLjhd878ko/uQi8k9Z3OLMgsDc8Y3BHL 5becaO9n9kNsbvIH5PVcozr4XmZiwj2/vHryMbyHazbOl68lAlg7DbCc/px1kvJnMISJ Pynl0SU5rk+NOk7P9rjqHQvfJiEnrWwHRr+GYiLK5qIBLOI5DMkorl89x4rHK810TIoj zJVw== X-Gm-Message-State: ACrzQf0X/6vDJWBUB8wA0AC4imbbzmmBmV5oDVTIroW4VAo81tjffH9n sSGshK9tK71+NAnoImN9fgYktQ== X-Google-Smtp-Source: AMsMyM6J6Dor4LjaeQvdKkX1FJT68wOSGUH5+/u7d4t1++RTN5ctc8WvL//DY4qpdoDWEqpjcWItaQ== X-Received: by 2002:a05:620a:4114:b0:6ee:dfb7:1584 with SMTP id j20-20020a05620a411400b006eedfb71584mr5776200qko.262.1666030856659; Mon, 17 Oct 2022 11:20:56 -0700 (PDT) Received: from localhost (cpe-174-109-170-245.nc.res.rr.com. [174.109.170.245]) by smtp.gmail.com with ESMTPSA id cf17-20020a05622a401100b0039c7b9522ecsm336321qtb.35.2022.10.17.11.20.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Oct 2022 11:20:56 -0700 (PDT) Date: Mon, 17 Oct 2022 14:20:55 -0400 From: Josef Bacik To: Kemeng Shi Cc: tj@kernel.org, axboe@kernel.dk, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] block: Correct comment for scale_cookie_change Message-ID: References: <20220929074055.30080-1-shikemeng@huawei.com> <20220929074055.30080-3-shikemeng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220929074055.30080-3-shikemeng@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 29, 2022 at 03:40:54PM +0800, Kemeng Shi wrote: > Default queue depth of iolatency_grp is unlimited, so we scale down > quickly(once by half) in scale_cookie_change. Remove the "subtract > 1/16th" part which is not the truth. > Ok sure, but at least update the comment to indicate what we actually do when scaling down. Thanks, Josef