From: Joel Fernandes <joel@joelfernandes.org>
To: Zqiang <qiang1.zhang@intel.com>
Cc: paulmck@kernel.org, frederic@kernel.org, rcu@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] srcu: Export srcu_check_nmi_safety() to modules
Date: Tue, 18 Oct 2022 01:57:44 +0000 [thread overview]
Message-ID: <Y04IGLudV7tYORUd@google.com> (raw)
In-Reply-To: <20221018013906.3890007-1-qiang1.zhang@intel.com>
On Tue, Oct 18, 2022 at 09:39:06AM +0800, Zqiang wrote:
> When enable CONFIG_PROVE_RCU and built modules, the following
> error appear:
>
> ERROR: modpost: "srcu_check_nmi_safety" [kernel/rcu/rcutorture.ko] undefined!
> ERROR: modpost: "srcu_check_nmi_safety" [kernel/rcu/rcuscale.ko] undefined!
>
> This commit fix it by exporting the srcu_check_nmi_safety().
>
> Signed-off-by: Zqiang <qiang1.zhang@intel.com>
Acked-by: Joel Fernandes (Google) <joel@joelfernandes.org>
thanks,
- Joel
> ---
> kernel/rcu/srcutree.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c
> index 382236dd5e46..bcd629f5f902 100644
> --- a/kernel/rcu/srcutree.c
> +++ b/kernel/rcu/srcutree.c
> @@ -651,6 +651,7 @@ void srcu_check_nmi_safety(struct srcu_struct *ssp, bool nmi_safe)
> }
> WARN_ONCE(old_nmi_safe_mask != nmi_safe_mask, "CPU %d old state %d new state %d\n", sdp->cpu, old_nmi_safe_mask, nmi_safe_mask);
> }
> +EXPORT_SYMBOL_GPL(srcu_check_nmi_safety);
> #endif /* CONFIG_PROVE_RCU */
>
> /*
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-10-18 1:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 1:39 [PATCH] srcu: Export srcu_check_nmi_safety() to modules Zqiang
2022-10-18 1:57 ` Joel Fernandes [this message]
2022-10-18 10:45 ` Frederic Weisbecker
2022-10-18 17:50 ` Paul E. McKenney
2022-10-18 19:05 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y04IGLudV7tYORUd@google.com \
--to=joel@joelfernandes.org \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=qiang1.zhang@intel.com \
--cc=rcu@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox