From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 383C5C433FE for ; Tue, 18 Oct 2022 08:22:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230477AbiJRIWa (ORCPT ); Tue, 18 Oct 2022 04:22:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230470AbiJRIWZ (ORCPT ); Tue, 18 Oct 2022 04:22:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A60E396221; Tue, 18 Oct 2022 01:22:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4AE78614B9; Tue, 18 Oct 2022 08:22:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCB95C433D6; Tue, 18 Oct 2022 08:22:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666081343; bh=rz7Gw5a3z7KjJRKfcO6V0p7vWLOfBAT0jPly/egslAA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nV3WAVYWjG5A6CPs+Lln8E7ThPtoz2FnrJbpAr4tn4rOy+XI1OlXNOCEcYj8R7prZ f7qLpq+L4eXNUrhMLdbMbEpM7t2CAQ7q9nhi7o9vQqEvC2E4snnOKwYbWMExfF1cAH iEDXq+RmzFWiWQsoG3Ndm2PW/Af+NZAjSkHHnw46wi/te8avj7CsTMLolroPE07Jd2 Sfk9qn9hERDVXolS6hi5o4fNHIQS+z6PeKXlnp3hhGh5a9GARYYRBYf0fNSIw/5002 nL57eT4b4/bZTg1xtyLrVw2D528e9Esj+SJzoi8k2zXT1zKjR1MYwW/qJspWO82Xhd WeOlFva1rQrJQ== Date: Tue, 18 Oct 2022 10:22:17 +0200 From: Matthias Brugger To: Cristian Ciocaltea Cc: Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Michael Zhu , Drew Fustini , Emil Renner Berthing , Conor Dooley , devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH v4 2/3] riscv: dts: starfive: Add common DT for JH7100 based boards Message-ID: References: <20221017210542.979051-1-cristian.ciocaltea@collabora.com> <20221017210542.979051-3-cristian.ciocaltea@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221017210542.979051-3-cristian.ciocaltea@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 18, 2022 at 12:05:41AM +0300, Cristian Ciocaltea wrote: > In preparation for adding initial device tree support for the StarFive > VisionFive board, which is similar with BeagleV Starlight, move most > of the content from jh7100-beaglev-starlight.dts to a new file, to be > shared between the two boards. > > Signed-off-by: Cristian Ciocaltea > Reviewed-by: Conor Dooley Reviewed-by: Matthias Brugger > --- > .../dts/starfive/jh7100-beaglev-starlight.dts | 153 +----------------- > ...aglev-starlight.dts => jh7100-common.dtsi} | 3 - > 2 files changed, 1 insertion(+), 155 deletions(-) > copy arch/riscv/boot/dts/starfive/{jh7100-beaglev-starlight.dts => jh7100-common.dtsi} (96%) > > diff --git a/arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dts b/arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dts > index f7a230110512..7cda3a89020a 100644 > --- a/arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dts > +++ b/arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dts > @@ -5,160 +5,9 @@ > */ > > /dts-v1/; > -#include "jh7100.dtsi" > -#include > -#include > -#include > +#include "jh7100-common.dtsi" > > / { > model = "BeagleV Starlight Beta"; > compatible = "beagle,beaglev-starlight-jh7100-r0", "starfive,jh7100"; > - > - aliases { > - serial0 = &uart3; > - }; > - > - chosen { > - stdout-path = "serial0:115200n8"; > - }; > - > - cpus { > - timebase-frequency = <6250000>; > - }; > - > - memory@80000000 { > - device_type = "memory"; > - reg = <0x0 0x80000000 0x2 0x0>; > - }; > - > - leds { > - compatible = "gpio-leds"; > - > - led-ack { > - gpios = <&gpio 43 GPIO_ACTIVE_HIGH>; > - color = ; > - function = LED_FUNCTION_HEARTBEAT; > - linux,default-trigger = "heartbeat"; > - label = "ack"; > - }; > - }; > -}; > - > -&gpio { > - i2c0_pins: i2c0-0 { > - i2c-pins { > - pinmux = - GPO_I2C0_PAD_SCK_OEN, > - GPI_I2C0_PAD_SCK_IN)>, > - - GPO_I2C0_PAD_SDA_OEN, > - GPI_I2C0_PAD_SDA_IN)>; > - bias-disable; /* external pull-up */ > - input-enable; > - input-schmitt-enable; > - }; > - }; > - > - i2c1_pins: i2c1-0 { > - i2c-pins { > - pinmux = - GPO_I2C1_PAD_SCK_OEN, > - GPI_I2C1_PAD_SCK_IN)>, > - - GPO_I2C1_PAD_SDA_OEN, > - GPI_I2C1_PAD_SDA_IN)>; > - bias-pull-up; > - input-enable; > - input-schmitt-enable; > - }; > - }; > - > - i2c2_pins: i2c2-0 { > - i2c-pins { > - pinmux = - GPO_I2C2_PAD_SCK_OEN, > - GPI_I2C2_PAD_SCK_IN)>, > - - GPO_I2C2_PAD_SDA_OEN, > - GPI_I2C2_PAD_SDA_IN)>; > - bias-disable; /* external pull-up */ > - input-enable; > - input-schmitt-enable; > - }; > - }; > - > - uart3_pins: uart3-0 { > - rx-pins { > - pinmux = - GPI_UART3_PAD_SIN)>; > - bias-pull-up; > - drive-strength = <14>; > - input-enable; > - input-schmitt-enable; > - slew-rate = <0>; > - }; > - tx-pins { > - pinmux = - GPO_ENABLE, GPI_NONE)>; > - bias-disable; > - drive-strength = <35>; > - input-disable; > - input-schmitt-disable; > - slew-rate = <0>; > - }; > - }; > -}; > - > -&i2c0 { > - clock-frequency = <100000>; > - i2c-sda-hold-time-ns = <300>; > - i2c-sda-falling-time-ns = <500>; > - i2c-scl-falling-time-ns = <500>; > - pinctrl-names = "default"; > - pinctrl-0 = <&i2c0_pins>; > - status = "okay"; > - > - pmic@5e { > - compatible = "ti,tps65086"; > - reg = <0x5e>; > - gpio-controller; > - #gpio-cells = <2>; > - > - regulators { > - }; > - }; > -}; > - > -&i2c1 { > - clock-frequency = <400000>; > - i2c-sda-hold-time-ns = <300>; > - i2c-sda-falling-time-ns = <100>; > - i2c-scl-falling-time-ns = <100>; > - pinctrl-names = "default"; > - pinctrl-0 = <&i2c1_pins>; > - status = "okay"; > -}; > - > -&i2c2 { > - clock-frequency = <100000>; > - i2c-sda-hold-time-ns = <300>; > - i2c-sda-falling-time-ns = <500>; > - i2c-scl-falling-time-ns = <500>; > - pinctrl-names = "default"; > - pinctrl-0 = <&i2c2_pins>; > - status = "okay"; > -}; > - > -&osc_sys { > - clock-frequency = <25000000>; > -}; > - > -&osc_aud { > - clock-frequency = <27000000>; > -}; > - > -&uart3 { > - pinctrl-names = "default"; > - pinctrl-0 = <&uart3_pins>; > - status = "okay"; > }; > diff --git a/arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dts b/arch/riscv/boot/dts/starfive/jh7100-common.dtsi > similarity index 96% > copy from arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dts > copy to arch/riscv/boot/dts/starfive/jh7100-common.dtsi > index f7a230110512..b93ce351a90f 100644 > --- a/arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dts > +++ b/arch/riscv/boot/dts/starfive/jh7100-common.dtsi > @@ -11,9 +11,6 @@ > #include > > / { > - model = "BeagleV Starlight Beta"; > - compatible = "beagle,beaglev-starlight-jh7100-r0", "starfive,jh7100"; > - > aliases { > serial0 = &uart3; > }; > -- > 2.38.0 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv