Re: [PATCH V3 1/2] dt-bindings: mtd: partitions: u-boot: allow dynamic subpartitions

Conor Dooley
2022-10-18T16:02:05Z

On Tue, Oct 18, 2022 at 05:55:14PM +0200, Rafał Miłecki wrote:
> On 18.10.2022 17:50, Conor Dooley wrote:
> > On Tue, Oct 18, 2022 at 05:42:01PM +0200, Rafał Miłecki wrote:
> > > From: Rafał Miłecki <rafal@milecki.pl>
> > >
> > > U-Boot partition may contain subpartitions. For example Broadcom
> > > includes environment data block in the middle of its U-Boot partition.
> > >
> > > This allows describing Broadcom's U-Boot env data and will allow
> > > referencing its NVMEM cell in the future.
> > >
> > > Reg: 118f3fbe517f4 ("dt-bindings: mtd: partitions: support label/name only partition")
> >
> > Pardon my ignorance here, but what is the significance of a "Reg" tag?
>
> That was meant to be "Ref:" and was meant to show commit that introduced
> concept of dynamic partitions. I thought it's a new feature not everyone
> may be familiar with yet. I thought it may help to review this patch.

Ah nw, I wasn't sure if it ws a typo or "Reg" short for regression.

>
> If that is pointless though could you Rob just drop those tags while
> applying, please? I guess I'll just let you decide.
>
>
> > > Ref: dd638202dfb65 ("dt-bindings: mtd: partitions: add additional example for qcom,smem-part")
> > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>