From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1221EC4332F for ; Tue, 18 Oct 2022 17:12:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229916AbiJRRMv (ORCPT ); Tue, 18 Oct 2022 13:12:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229835AbiJRRMt (ORCPT ); Tue, 18 Oct 2022 13:12:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B878CCBFE9 for ; Tue, 18 Oct 2022 10:12:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 52E4061637 for ; Tue, 18 Oct 2022 17:12:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60370C433D6; Tue, 18 Oct 2022 17:12:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666113167; bh=k3hmzAggwq111S6Ua4IcYi9FLc6QlVCC6j+yxzC7G9Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U+5icxseHVI4b2nRDz4rt+5aaJzbqsBd3949EAcrLl5P7lqP152Anm7sOF8OycEyW +58+vpzLk26Bnp5lr6sOf2Av5RtP0xZC4ajRfHIsNHf6P+TSf/bok80wNAzy7nhdg4 NuVAjx5OQYvhLDXoCFOVq/qdCDlRS3Xz/kc+g8nw= Date: Tue, 18 Oct 2022 19:12:45 +0200 From: Greg KH To: Deepak R Varma Cc: outreachy@lists.linux.dev, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: most: dim2: read done_buffers count locally from HDM channel Message-ID: References: <83fd237d2ac157d234e9c7cce1206904c2d8773d.1666105876.git.drv@mailo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83fd237d2ac157d234e9c7cce1206904c2d8773d.1666105876.git.drv@mailo.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 18, 2022 at 10:19:21PM +0530, Deepak R Varma wrote: > The function dim_get_channel_state only serves to initialize the ready and > done_buffers fields of the structure passed as its second argument. In > service_done_flag, this structure is never used again and the only purpose > of the call is to get the value that is put in the done_buffers field. > But that value is just the done_sw_buffers_number field of the call's > first argument. So the whole call is useless, and we can just replace it > with an access to this field. > > This change implies that the variable st is no longer used, so drop it as > well. > > Signed-off-by: Deepak R Varma > --- > > PLEASE NOTE: > 1. I have only built the module on my machine, but have not tested it. > I am not sure how to test this change. I am willing to test it with > appropriate guidance provided I have the necessary hardware. > 2. This was a standalone patch earlier. It is now combined into a patch set > with another patch for the same driver. Hence I am carry forwarding the > change log for this patch here: > > Changes in v3: > 1. The patch log message is further improved. This revised verbiage is as > thankfully provided by julia.lawall@inria.fr > > Changes in v2: > 1. Update patch log message to be more descriptive about the reason for change. > Feedback provided by julia.lawall@inria.fr > You need to say this is a v3 in the subject line as documented :(