From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73D12C433F5 for ; Fri, 7 Oct 2022 13:16:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229827AbiJGNQS (ORCPT ); Fri, 7 Oct 2022 09:16:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229590AbiJGNQQ (ORCPT ); Fri, 7 Oct 2022 09:16:16 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8D9FCBFED for ; Fri, 7 Oct 2022 06:16:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 785F961D0B for ; Fri, 7 Oct 2022 13:16:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E96DBC433D6; Fri, 7 Oct 2022 13:16:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665148573; bh=UB2Z41XKQq+aDykwR9QkpIVEGsdZTMB900AR+oPYcEQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZSXl1ocwinGvuprFGb7jSMoIdmwB0YlKbG892m+6ou/R7iSAX8Gx9ptlFuniyS4Nw JHbOQgvRYjBdkd64K58+pJGaIy28KfBa9/euUncn7F4+j9Y+DexzKIDx8FN7jZwKqk 7KdENGiHEIT1sKmQQAVyr/AzA3sKLGM4paLPiaeJZiNmNJsj0ZsH1NPtkcB3mo7gGb kHyM55Prw/j+w4BdNIq9oTIgG8IOx5yDeLiyud09FNea1c/fFa73FW7N6zckmEbo9W V/7IoYypN5ZdsxG5uFfokuj/DJqJLGXCbPmh8MR7PNv0L2aCL8btpjtrmqblimyNPy wODhS8ksNoB/A== Date: Fri, 7 Oct 2022 14:16:09 +0100 From: Lee Jones To: Linus Torvalds Cc: Mark Brown , Linux Kernel Mailing List Subject: Re: [GIT PULL] Backlight for v6.1 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 05 Oct 2022, Linus Torvalds wrote: > On Wed, Oct 5, 2022 at 5:44 AM Lee Jones wrote: > > > > - Add support for MediaTek MT6370 Backlight > > Hmm. This new driver has a > > depends on MFD_MT6370 > > but there is no such symbol anywhere. > > It turns out the same is true of the MT6370 regulator driver that was > added during the previous merge window. > > I do see that MFD_MT6370 in linux-next, but I don't see any pull > request for this, and now that I started looking I do see that we had > this already in 6.0. > > I do *not* believe that it's ok to randomly take "drivers" that depend > on functionality that hasn't even been merged yet, and that are > basically just dead code but hidden away this non-obvious way. > > I've pulled this, but I want to just state that this is bad, bad, bad. > If it has dependencies that aren't met, it damn well shouldn't be sent > upstream in a form where upstream can't even build test the thing. PR satisfying this dependency was submitted the following day: https://lore.kernel.org/all/Yz6Zi7B2RS16sXhT@google.com/ -- Lee Jones [李琼斯]