From: Sean Christopherson <seanjc@google.com>
To: Hao Peng <flyingpenghao@gmail.com>
Cc: pbonzini@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kvm: x86: keep srcu writer side operation mutually exclusive
Date: Fri, 7 Oct 2022 17:12:49 +0000 [thread overview]
Message-ID: <Y0BeEVxkDkctmTIX@google.com> (raw)
In-Reply-To: <CAPm50a+aygp3T1mNjzGXtL2nyNm-mHFZ3YO8F7eO0gCxZDuQsA@mail.gmail.com>
On Sat, Oct 08, 2022, Hao Peng wrote:
> From: Peng Hao <flyingpeng@tencent.com>
>
> Synchronization operations on the writer side of SRCU should be
> invoked within the mutex.
Why? Synchronizing SRCU is necessary only to ensure that all previous readers go
away before the old filter is freed. There's no need to serialize synchronization
between writers. The mutex ensures each writer operates on the "new" filter that's
set by the previous writer, i.e. there's no danger of a double-free. And the next
writer will wait for readers to _its_ "new" filter.
I think it's a moot point though, as this is a subset of patch I posted[*] to fix
other issues with the PMU event filter.
[*] https://lore.kernel.org/all/20220923001355.3741194-2-seanjc@google.com
next prev parent reply other threads:[~2022-10-07 17:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 16:00 [PATCH] kvm: x86: keep srcu writer side operation mutually exclusive Hao Peng
2022-10-07 17:12 ` Sean Christopherson [this message]
2022-10-09 11:45 ` Hao Peng
2022-10-10 17:38 ` Sean Christopherson
2022-10-24 3:27 ` Hao Peng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0BeEVxkDkctmTIX@google.com \
--to=seanjc@google.com \
--cc=flyingpenghao@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox