From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E230EC433F5 for ; Fri, 7 Oct 2022 17:18:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229592AbiJGRSS (ORCPT ); Fri, 7 Oct 2022 13:18:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbiJGRSO (ORCPT ); Fri, 7 Oct 2022 13:18:14 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEE06D57D3; Fri, 7 Oct 2022 10:18:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Qu0RZlUOKHKbdJ93oyFutpaLoUL4bQrVrDVJWi930ac=; b=Q0GO23CTsRrxoMOQjBT07b+fbV xuHE10+DAr4bRVKdI21rVUamN7uWea2x2WNRmw/k4O6MPz8tcxa0e8gdbRgtcikOsgRm6U9bVNtj9 NemvdrSzkjq+5qZFSIqDfYcP8/khTwRJLWO0ENyhwlnjl6OavwwZ8pJQTslvlxA2g5xz9ZiMn/EMg /E+xc4H9GfCHrxZhwZiHBU/LTfFOo8WVgshOfZdrGzyNdpgp83WFv+VRxyL/XYtl5vEpxXugq7AaZ 2mOeZtggX+2Xr6/40reAzY+9g41G18YaYwerbGXemmx2SzKVpAHhNMH0SqaJq6UMRCnjJCBos635x D2zSOXeQ==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1ogqyr-0022Yg-Rl; Fri, 07 Oct 2022 17:17:50 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 911D3300155; Fri, 7 Oct 2022 19:17:43 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 753BC2BD94364; Fri, 7 Oct 2022 19:17:43 +0200 (CEST) Date: Fri, 7 Oct 2022 19:17:43 +0200 From: Peter Zijlstra To: Miguel Ojeda Cc: Linus Torvalds , Greg Kroah-Hartman , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, patches@lists.linux.dev, Jarkko Sakkinen , Kees Cook , Alex Gaynor , Wedson Almeida Filho , David Gow , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , linux-doc@vger.kernel.org Subject: Re: [PATCH v10 25/27] x86: enable initial Rust support Message-ID: References: <20220927131518.30000-1-ojeda@kernel.org> <20220927131518.30000-26-ojeda@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220927131518.30000-26-ojeda@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 27, 2022 at 03:14:56PM +0200, Miguel Ojeda wrote: > Note that only x86_64 is covered and not all features nor mitigations > are handled, but it is enough as a starting point and showcases > the basics needed to add Rust support for a new architecture. Does it fail the build if required options are missing? Specifically are things like kCFI and IBT enabled? Silently not handling those will result in an unbootable image. As to missing mitigations; does it at least visibly warn people? I'm very *very* uncomfortable having to 'support' a half-arsed compiler like this.