From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B076C433F5 for ; Sun, 9 Oct 2022 18:18:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230156AbiJISSZ (ORCPT ); Sun, 9 Oct 2022 14:18:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230233AbiJISSP (ORCPT ); Sun, 9 Oct 2022 14:18:15 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27AC923B for ; Sun, 9 Oct 2022 11:18:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D137AB80D13 for ; Sun, 9 Oct 2022 18:18:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47301C433D6; Sun, 9 Oct 2022 18:18:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1665339492; bh=iqQq41+17rFhUiR/5kPv3GL3DyNm2+qz9wuHcaMPe+w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cx3QoND2P6onLWlv8CbxTpmDlX7tLfTZf5CLAeOGQY4GAH7x+DJCGHuWHRyLHu1lU 5kqneydhaLOkWij4CeaFqWzsrDQVg22gDnN0Ol33aIoTyNHyIwRs9iu41q4GluUfPv mruSn1QLaCcC4xTE56VyGe79nxxN58ZzQ6vv5MFo= Date: Sun, 9 Oct 2022 20:18:55 +0200 From: Greg Kroah-Hartman To: Rui Li Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8192e: Fix braces/tabs/number/OOM warnings Message-ID: References: <166528776854.9.8249842126243786800.67724771@lirui.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <166528776854.9.8249842126243786800.67724771@lirui.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 09, 2022 at 11:55:36AM +0800, Rui Li wrote: > Fix warnings generated by checkpatch.pl: unnecessary braces after > if, too many leading tabs, int type conversion before number, > OOM message ourput. > > Signed-off-by: Rui Li > --- > .../staging/rtl8192e/rtl8192e/r8192E_dev.c | 3 +- > .../staging/rtl8192e/rtl8192e/r8192E_phy.c | 9 ++---- > drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 3 -- > drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 30 +++++++------------ > drivers/staging/rtl8192e/rtl819x_BAProc.c | 5 ++-- > drivers/staging/rtl8192e/rtl819x_HTProc.c | 1 + > drivers/staging/rtl8192e/rtllib_rx.c | 8 ++--- > drivers/staging/rtl8192e/rtllib_softmac_wx.c | 7 ++--- > 8 files changed, 25 insertions(+), 41 deletions(-) > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot