public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jiangshan Yi <13667453960@163.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Jiangshan Yi <yijiangshan@kylinos.cn>,
	k2ci <kernel-bot@kylinos.cn>
Subject: Re: [PATCH] staging: rtl8723bs: fix spelling typo in comment
Date: Sun, 9 Oct 2022 20:21:46 +0200	[thread overview]
Message-ID: <Y0MROo7YMrVoYyZ8@kroah.com> (raw)
In-Reply-To: <20221009065647.2635700-1-13667453960@163.com>

On Sun, Oct 09, 2022 at 02:56:47PM +0800, Jiangshan Yi wrote:
> From: Jiangshan Yi <yijiangshan@kylinos.cn>

Then why is this being sent from a 163.com address?

What is wrong with using your real mail server?

> 
> Fix spelling typo in comment.
> 
> K2ci (Kylin Continuous Integration) is a code pre-verification tool
> independently developed by KylinSoft, which is used for ensuring the
> code quality of code submission. K2ci includes the comment check tool
> notes_check.
> 
> This spelling typo was found using notes_check tool.
> 
> Reported-by: k2ci <kernel-bot@kylinos.cn>
> Signed-off-by: Jiangshan Yi <yijiangshan@kylinos.cn>
> ---
>  drivers/staging/rtl8723bs/core/rtw_cmd.c     | 2 +-
>  drivers/staging/rtl8723bs/core/rtw_efuse.c   | 2 +-
>  drivers/staging/rtl8723bs/include/sta_info.h | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index d3f10a3cf972..a421c430164a 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -1656,7 +1656,7 @@ u8 rtw_c2h_packet_wk_cmd(struct adapter *padapter, u8 *pbuf, u16 length)
>  	return res;
>  }
>  
> -/* dont call R/W in this function, beucase SDIO interrupt have claim host */
> +/* don't call R/W in this function, because SDIO interrupt have claim host */

That is not a spelling fix, but rather a "punctuation" fix if you want
to be picky :)

>  /* or deadlock will happen and cause special-systemserver-died in android */
>  u8 rtw_c2h_wk_cmd(struct adapter *padapter, u8 *c2h_evt)
>  {
> diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> index 06e727ce9cc2..71800917d132 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> @@ -277,7 +277,7 @@ bool		bPseudoTest)
>  	return bResult;
>  }
>  
> -/*  11/16/2008 MH Write one byte to reald Efuse. */
> +/*  11/16/2008 MH Write one byte to real Efuse. */

The date should just be removed entirely, right?

>  u8 efuse_OneByteWrite(struct adapter *padapter, u16 addr, u8 data, bool bPseudoTest)
>  {
>  	u8 tmpidx = 0;
> diff --git a/drivers/staging/rtl8723bs/include/sta_info.h b/drivers/staging/rtl8723bs/include/sta_info.h
> index 69c377eeeaf0..1c3f83867cb0 100644
> --- a/drivers/staging/rtl8723bs/include/sta_info.h
> +++ b/drivers/staging/rtl8723bs/include/sta_info.h
> @@ -190,7 +190,7 @@ struct sta_info {
>  
>  	/* ODM_STA_INFO_T */
>  	/*  ================ODM Relative Info ======================= */
> -	/*  Please be care, dont declare too much structure here. It will cost memory * STA support num. */
> +	/*  Please be care, don't declare too much structure here. It will cost memory * STA support num. */

Same here.

thanks,

greg k-h

  reply	other threads:[~2022-10-09 18:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-09  6:56 [PATCH] staging: rtl8723bs: fix spelling typo in comment Jiangshan Yi
2022-10-09 18:21 ` Greg KH [this message]
2022-10-10  3:07   ` Yi Jiangshan
2022-10-10  6:23     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y0MROo7YMrVoYyZ8@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=13667453960@163.com \
    --cc=kernel-bot@kylinos.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=yijiangshan@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox