From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Soha Jin <soha@lohu.info>, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] Case-insensitive match_string and fwnode_is_compatible()
Date: Mon, 10 Oct 2022 09:23:33 +0300 [thread overview]
Message-ID: <Y0O6ZZe6RqlibDxB@smile.fi.intel.com> (raw)
In-Reply-To: <20221009162155.1318-1-soha@lohu.info>
On Mon, Oct 10, 2022 at 12:21:52AM +0800, Soha Jin wrote:
> I am introducing these patches for the patch for ethernet driver which I
> will send later.
>
> In Patch 1, I abstract `match_string` to `__match_string` with a comparison
> function, make the original name calling it with `strcmp` and add
> `match_string_nocase` calling it with `strcasecmp`.
>
> In Patch 2 & 3, I implement `{device,fwnode}_property_match_string_nocase`
> and `fwnode_is_compatible` for compatible property matching.
Let's ask Rob about usage of case-insensitive comparator for compatible
strings.
So, why do we have such in the OF code and do we really need it in the modern
world?
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-10-10 6:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-09 16:21 [PATCH 0/3] Case-insensitive match_string and fwnode_is_compatible() Soha Jin
2022-10-09 16:21 ` [PATCH 1/3] string: add match_string_nocase() for case-insensitive match Soha Jin
2022-10-09 18:24 ` Greg Kroah-Hartman
2022-10-10 3:02 ` Soha Jin
2022-10-10 6:24 ` 'Greg Kroah-Hartman'
2022-10-10 7:36 ` Soha Jin
2022-10-09 16:21 ` [PATCH 2/3] device property: add {device,fwnode}_property_match_string_nocase() Soha Jin
2022-10-09 18:25 ` Greg Kroah-Hartman
2022-10-09 18:40 ` kernel test robot
2022-10-09 18:40 ` kernel test robot
2022-10-09 16:21 ` [PATCH 3/3] device property: add fwnode_is_compatible() for compatible match Soha Jin
2022-10-09 18:26 ` Greg Kroah-Hartman
2022-10-09 18:24 ` [PATCH 0/3] Case-insensitive match_string and fwnode_is_compatible() Greg Kroah-Hartman
2022-10-10 3:07 ` Soha Jin
2022-10-10 6:26 ` 'Greg Kroah-Hartman'
2022-10-10 7:40 ` Soha Jin
2022-10-10 6:23 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0O6ZZe6RqlibDxB@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=djrscally@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=soha@lohu.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox