From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 745F8C433FE for ; Mon, 10 Oct 2022 06:23:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231634AbiJJGXx (ORCPT ); Mon, 10 Oct 2022 02:23:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231635AbiJJGXj (ORCPT ); Mon, 10 Oct 2022 02:23:39 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EE9151A2D; Sun, 9 Oct 2022 23:23:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665383018; x=1696919018; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=9JYb5cHyGp+9KJ6PeduxCp/1k+kpG2Pd37pUyCuJev4=; b=NG/76/+V9XTWCMXKrOS4+HwtMygPbVjcZwisbk6a/3hc38lN6M/7MNKK fyMcGcpXqBuxhVSS28ABMOcxu77lccSEk1BpFqa3+CNtdyLYXVzA3CFmI aB17BzUpdy80U8YTkJEBAj79M3p6GfvNpxgli7YPi/fuMgupEeb4LjQ63 CUnQJNLtTmyD3XGvjN6ETD7vl4trSlEfkytkktFTqIE32eM3WVwANS3wm RK/ohATqDH0AP3zdlLSKb4j6im6f/wC3ZIH24C8HOhNOGogCOEwbhxwHU 7O0ClWXWa53yV/8e6e0FKPsoibNFOXXbOyUWvxDuazRZJuPlM0CbAh/yi g==; X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="291439346" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="291439346" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2022 23:23:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="659043114" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="659043114" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001.jf.intel.com with ESMTP; 09 Oct 2022 23:23:35 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1ohmCL-004kNx-2m; Mon, 10 Oct 2022 09:23:33 +0300 Date: Mon, 10 Oct 2022 09:23:33 +0300 From: Andy Shevchenko To: Soha Jin , Rob Herring , devicetree@vger.kernel.org Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Daniel Scally , Heikki Krogerus , Sakari Ailus , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] Case-insensitive match_string and fwnode_is_compatible() Message-ID: References: <20221009162155.1318-1-soha@lohu.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221009162155.1318-1-soha@lohu.info> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 10, 2022 at 12:21:52AM +0800, Soha Jin wrote: > I am introducing these patches for the patch for ethernet driver which I > will send later. > > In Patch 1, I abstract `match_string` to `__match_string` with a comparison > function, make the original name calling it with `strcmp` and add > `match_string_nocase` calling it with `strcasecmp`. > > In Patch 2 & 3, I implement `{device,fwnode}_property_match_string_nocase` > and `fwnode_is_compatible` for compatible property matching. Let's ask Rob about usage of case-insensitive comparator for compatible strings. So, why do we have such in the OF code and do we really need it in the modern world? -- With Best Regards, Andy Shevchenko