From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Patrice Chotard <patrice.chotard@foss.st.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1 1/1] pinctrl: st: Avoid using of_node member of struct gpio_chip
Date: Mon, 10 Oct 2022 09:47:56 +0300 [thread overview]
Message-ID: <Y0PAHF8lZUpYE3CW@smile.fi.intel.com> (raw)
In-Reply-To: <Y0O4GNR28kSOR1Iu@google.com>
On Sun, Oct 09, 2022 at 11:13:44PM -0700, Dmitry Torokhov wrote:
> On Tue, Oct 04, 2022 at 03:54:49PM +0300, Andy Shevchenko wrote:
> > The of_node member of the struct gpio_chip is obsoleted and
> > shouldn't be used. It will be removed in the future.
> >
> > Replace its use in st_pctl_dt_calculate_pin() by comparing
> > the fwnode pointers.
> >
> > Fixes: e75729b2f63f ("pinctrl: st: stop abusing of_get_named_gpio()")
...
> Are you sure chip's fwnode is properly set here (without your other
> patch)? I don't believe the driver sets it up, and I don't think gpiolib
> maps it from the gpio_chip->of_node.
>
> Actually, there is another reference to of_node in gpio chip in
> st_gpiolib_register_bank()...
You are right, this patch has been made on top of another not yet published
one. Hence, nothing to fix it right now.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-10-10 6:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 12:54 [PATCH v1 1/1] pinctrl: st: Avoid using of_node member of struct gpio_chip Andy Shevchenko
2022-10-10 6:13 ` Dmitry Torokhov
2022-10-10 6:47 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0PAHF8lZUpYE3CW@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrice.chotard@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox