Re: [PATCH v2 0/2] usb: dwc3: revert OTG changes for Intel Merrifield

Andy Shevchenko
2022-10-17T23:14:04Z

On Mon, Oct 17, 2022 at 10:22:46PM +0000, Thinh Nguyen wrote:
> On Mon, Oct 17, 2022, Andrey Smirnov wrote:
> > On Tue, Sep 27, 2022 at 8:53 AM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > As agreed with the author, the v5.19 change is going to be reverted by
> > > this series, so we will collaborate on a new one in the future that
> > > brings no regressions.
> > >
> > > Changelog v2:
> > > - added Cc: stable@ and Fixes tags (Greg)
> > > - rewritten cover letter to point out what the version is touched and
> > > what the decision made with the author of the original change (Greg)
> > > - fixed the placement of one piece of code (Andrey)
> > > - added Tested-by tags (Ferry)
> > >
> > > Andy Shevchenko (2):
> > > Revert "USB: fixup for merge issue with "usb: dwc3: Don't switch OTG
> > > -> peripheral if extcon is present""
> > > Revert "usb: dwc3: Don't switch OTG -> peripheral if extcon is
> > > present"
> > >
> >
> > To spare everyone the need to read extra long thread in
> > [PATCH v2 2/2] Revert "usb: dwc3: Don't switch OTG -> peripheral if
> > extcon is present"
> >
> > NAK, on the whole series. The regression doesn't repro on my
> > Edison/Merriefield setup and doesn't repro on the original reporter's
> > HW with my build, so it's very much unclear what's going on and what
> > the problem is and until it is the revert doesn't seem warranted.
> > Please don't apply this.
> >
>
> Thanks for your tests. The series was already applied. It's a bit messy,
> but it seems like we need to revert series as there are already reports
> that this it already breaks other setups.

I will prepare a patch to reapply what was before the revert.
Sorry for the mess.

--
With Best Regards,
Andy Shevchenko