From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E12A1C433F5 for ; Mon, 10 Oct 2022 15:51:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229917AbiJJPvx (ORCPT ); Mon, 10 Oct 2022 11:51:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229837AbiJJPvs (ORCPT ); Mon, 10 Oct 2022 11:51:48 -0400 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A3EA3207C for ; Mon, 10 Oct 2022 08:51:47 -0700 (PDT) Received: by mail-pg1-x536.google.com with SMTP id u71so3089274pgd.2 for ; Mon, 10 Oct 2022 08:51:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hIt0t1xcXdrtBGcH8SAZ/36EkM9pDcb6p9X18pwFo3A=; b=nPSFYCtPHQwzrIic0FPQoSaiXMf/bqEr+NIF9QG34YGpgv0Y/MkS7bsAmcURO1Z4BE DCUiUMp3qTAkwWXkPKIaVUtRC1JoiuPwNg21Uy0q1twp6+aPp11h/xKp2R3mRSxIZzEh Z8NQwFvt64PbTvohDHURJfr5HRCaXQnwH3vCpG6c0X+HWys41Kuh6hXzfk5Fpy0EE7YG YwROL7ySnn92VooL+YnOK79UBnvIndBHDx+uITAVMqAsmRTw/k0CxRMexXIy+tnJhoar LS7z3EZ38X2nngpxzRYiNLg/trCtN2Afzvg4N8SJsVwXlDn+iRrc5L1ZEkoY43HtVA3u Y8AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hIt0t1xcXdrtBGcH8SAZ/36EkM9pDcb6p9X18pwFo3A=; b=xgAkTTkLQhyXqJi1ntwAfgLe3DqENuKlJt/oG/L4VFEzuWNCkr8oDWl6NcE+q2itrQ Pnu1Q08KEGV1oGxioo+r2SoA+OGnES1uWgSgnNojPUiQ1ZjpLl9yNkNfWFCkZugsvn0p 2VXrp94AVFKBHb+MjPSg+9mZaNzEX+pQ5/5ndLm0Y3fL8ADFj18Qf4UDTEp8cc9fKy1O KvQwktbQl7a9HFgzuGupiG83Ly8dHPg4DjMt3bYI4Dw0LNuX0CntaR2mmYgwDyJ7dg4F blsH1FKx4DqyioZtEwslRC3w5hohXYzoth36PkAdE8uiRoOWzO6aZghqZVlq+HlKwY11 uoqA== X-Gm-Message-State: ACrzQf1RAognSW827V5KSXQck+b/kV+mRAzViG9ZLyTihhAx1g/Ss/sh WMFlQH8fZaHwAaBKbMRnp3Ndkw== X-Google-Smtp-Source: AMsMyM6QwCJ6EiilWWvDV3nia1JeXo3WAhNWv6TW4Xy+6W2XVrrSm9f3cIQ//TqNRuEgS79t1cRz0g== X-Received: by 2002:a63:b5d:0:b0:45f:d7d0:5808 with SMTP id a29-20020a630b5d000000b0045fd7d05808mr12144049pgl.330.1665417106626; Mon, 10 Oct 2022 08:51:46 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id d19-20020a170903209300b00173411a4385sm6788953plc.43.2022.10.10.08.51.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Oct 2022 08:51:45 -0700 (PDT) Date: Mon, 10 Oct 2022 15:51:41 +0000 From: Sean Christopherson To: Santosh Shukla Cc: Paolo Bonzini , Vitaly Kuznetsov , Jim Mattson , Joerg Roedel , Tom Lendacky , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mlevitsk@redhat.com, mail@maciej.szmigiero.name Subject: Re: [PATCHv4 0/8] Virtual NMI feature Message-ID: References: <20220829100850.1474-1-santosh.shukla@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 10, 2022, Santosh Shukla wrote: > > > On 10/7/2022 12:10 AM, Sean Christopherson wrote: > > On Mon, Aug 29, 2022, Santosh Shukla wrote: > >> If NMI virtualization enabled and NMI_INTERCEPT bit is unset > >> then HW will exit with #INVALID exit reason. > >> > >> To enable the VNMI capability, Hypervisor need to program > >> V_NMI_ENABLE bit 1. > >> > >> The presence of this feature is indicated via the CPUID function > >> 0x8000000A_EDX[25]. > > > > Until there is publicly available documentation, I am not going to review this > > any further. This goes for all new features, e.g. PerfMonv2[*]. I understand > > the need and desire to get code merged far in advance of hardware being available, > > but y'all clearly have specs, i.e. this is a very solvable problem. Throw all the > > disclaimers you want on the specs to make it abundantly clear that they are for > > preview purposes or whatever, but reviewing KVM code without a spec just doesn't > > work for me. > > > > Sure Sean. > > I am told that the APM should be out in the next couple of weeks. Probably too late to be of much value for virtual NMI support, but for future features, it would be very helpful to release "preview" documentation ASAP so that we don't have to wait for the next APM update, which IIUC only happens ~2 times a year.