From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id B87DCC433FE
	for <linux-kernel@archiver.kernel.org>; Mon, 10 Oct 2022 15:04:08 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229759AbiJJPEH (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 10 Oct 2022 11:04:07 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50660 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229462AbiJJPEF (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 10 Oct 2022 11:04:05 -0400
Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59FEC501B5;
        Mon, 10 Oct 2022 08:04:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject:
        Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:
        Content-ID:Content-Description:Content-Disposition:In-Reply-To:References;
        bh=rF8tmrJKpxqMBEvGCOCH0nL3X3grWDBvLB6F8L3Fm50=; b=pOx84U6jkuZVjDn2vNO8Mz/oIV
        Xl76tVLvFyOnqlswMhtCw4f9Lti55gQD+zaoyHtqm6W/oJt3+BalQ2M6XG4MDM8EfZ+GdZovkt3Gs
        eaF/Loz2rkUfY2IOmXwffCxB/dJ3FGUWozUILS05kXF83QSvFThdTAcJtRgm9oy3N3Hg=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2)
        (envelope-from <andrew@lunn.ch>)
        id 1ohuJT-001dAc-E1; Mon, 10 Oct 2022 17:03:27 +0200
Date:   Mon, 10 Oct 2022 17:03:27 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Soha Jin <soha@lohu.info>
Cc:     Heiner Kallweit <hkallweit1@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Russell King <linux@armlinux.org.uk>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: mdiobus: add fwnode_phy_is_fixed_link()
Message-ID: <Y0Q0P4MlTXmzkJSG@lunn.ch>
References: <20221009162006.1289-1-soha@lohu.info>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221009162006.1289-1-soha@lohu.info>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 10, 2022 at 12:20:06AM +0800, Soha Jin wrote:
> A helper function to check if PHY is fixed link with fwnode properties.
> This is similar to of_phy_is_fixed_link.

You need to include a user of this new function.

Also, not that ACPI only defines the 'new binding' for fixed-link.  If
this is being called on a device which is ACPI underneath, it should
only return true for the 'new binding', not the old binding.

     Andrew