From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4ACDEC433FE for ; Mon, 10 Oct 2022 16:32:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229714AbiJJQb7 (ORCPT ); Mon, 10 Oct 2022 12:31:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229545AbiJJQb4 (ORCPT ); Mon, 10 Oct 2022 12:31:56 -0400 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02E7F58B41 for ; Mon, 10 Oct 2022 09:31:55 -0700 (PDT) Received: by mail-pg1-x533.google.com with SMTP id r18so10644512pgr.12 for ; Mon, 10 Oct 2022 09:31:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cef4tENcEln1YpvYHQqhPeC7gMKImdcmFkiWo05D8o0=; b=PQFFoZUc+lDbIKkce4B2VR38yIj97UhKeRmHUeEaanlFq7GdI0oJfH2/datNrT3ac+ UTFRW4f6tRQ8TfvPeM3KSRbYd5MA8kqTEvnV14XogbwCnoGijmBCBbKdGEFxtzoIvDBk 4NBgSB95fW/mighg6OSyReveap83AZFvJusdWM+MYs7E8t1xW9YLM98dZtIPWfVaNzOW UBOBigXrKS+mdm3oVtingOs03WyeQ1Hf0YxfbfBaRKQy0mflM5DeyNLYnCgvtddVY5+v 0wyYOt4sb0ovI4puHffpjlNFeM63d3hnca7IXcgqrcf6/3esQOXZWBHxWF375HXM/wQK cK7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cef4tENcEln1YpvYHQqhPeC7gMKImdcmFkiWo05D8o0=; b=TWsgXKZjBd7ZqIjIVjhX1SPXCvYP653zHblJLjhL1W0INDy6AWgXcsMso3gRAhH0Fw rVIMVVmr00NiFCnHZViCx3FcPptfrrqbJRdsnKBf7PKGi3ZzwC/4quOP37l3FxwTxsjo RIPGVl2IyDj9DWWtbRkEffYJzNbjZoOh1MGJ8rN1CS3dJuS+G5WRNRcjB8oLe3I7PZI0 vwvDJYXgB+AMfjvX+m/I/73rRjE67nh4FPfEWznfKgFCHK/UH/VsQce01fO6nlVKGzUZ PEgbcC9Uj2NLfUQijKeo4t1cGEwNN8dUq4P7uMYJMCZuZqaMInF2xaLZy0Ip/rE3JDox gXpg== X-Gm-Message-State: ACrzQf0Gzy7JocV04TIhKp0oxFj/IvAWd5bw5xEG+WD2mxMOEUDe90pZ oScepEea7+dVF9cKOzovIzyVUQ== X-Google-Smtp-Source: AMsMyM6qMVfnGNSFco0Sh4eauG3X9+2OZTzj81+MF94q6XAf4Z7ObzGbHU8Z/N2phVDyoP/4+ad7ig== X-Received: by 2002:a65:6954:0:b0:445:fdb8:738e with SMTP id w20-20020a656954000000b00445fdb8738emr16712484pgq.520.1665419514448; Mon, 10 Oct 2022 09:31:54 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id ij2-20020a170902ab4200b00176ab6a0d5fsm6918110plb.54.2022.10.10.09.31.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Oct 2022 09:31:53 -0700 (PDT) Date: Mon, 10 Oct 2022 16:31:50 +0000 From: Sean Christopherson To: Yan Zhao Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Mingwei Zhang , David Matlack , Ben Gardon Subject: Re: [PATCH v5 7/7] KVM: x86/mmu: explicitly check nx_hugepage in disallowed_hugepage_adjust() Message-ID: References: <20220930234854.1739690-1-seanjc@google.com> <20220930234854.1739690-8-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 10, 2022, Yan Zhao wrote: > On Fri, Sep 30, 2022 at 11:48:54PM +0000, Sean Christopherson wrote: > > diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c > > index 54005b7f1499..688beed3a41e 100644 > > --- a/arch/x86/kvm/mmu/mmu.c > > +++ b/arch/x86/kvm/mmu/mmu.c > > @@ -3110,6 +3110,11 @@ void disallowed_hugepage_adjust(struct kvm_page_fault *fault, u64 spte, int cur_ > > cur_level == fault->goal_level && > > is_shadow_present_pte(spte) && > > !is_large_pte(spte)) { > > + u64 page_mask; > > + > > + if (!spte_to_child_sp(spte)->nx_huge_page_disallowed) > > + return; > Merge this "if" with the upper level "if" ? Ya, good call. The separate check is no longer necessary now that the superfluous smp_rmb() is gone. That'll minimize the diff to.