From: Andrew Lunn <andrew@lunn.ch>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Soha Jin <soha@lohu.info>, Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: mdiobus: add fwnode_phy_is_fixed_link()
Date: Mon, 10 Oct 2022 18:52:01 +0200 [thread overview]
Message-ID: <Y0RNsZUnV0GJqIlO@lunn.ch> (raw)
In-Reply-To: <Y0RLm0qU8MwGt40d@shell.armlinux.org.uk>
On Mon, Oct 10, 2022 at 05:43:07PM +0100, Russell King (Oracle) wrote:
> On Mon, Oct 10, 2022 at 05:03:27PM +0200, Andrew Lunn wrote:
> > On Mon, Oct 10, 2022 at 12:20:06AM +0800, Soha Jin wrote:
> > > A helper function to check if PHY is fixed link with fwnode properties.
> > > This is similar to of_phy_is_fixed_link.
> >
> > You need to include a user of this new function.
> >
> > Also, not that ACPI only defines the 'new binding' for fixed-link. If
> > this is being called on a device which is ACPI underneath, it should
> > only return true for the 'new binding', not the old binding.
>
> Do we want to support the "managed" property in the fwnode variant,
> or persuade people to switch to phylink if they want that?
managed has been documented in
Documentation/firmware-guide/acpi/dsd/phy.rst so i think we need to
support it.
Andrew
prev parent reply other threads:[~2022-10-10 16:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-09 16:20 [PATCH] net: mdiobus: add fwnode_phy_is_fixed_link() Soha Jin
2022-10-10 15:03 ` Andrew Lunn
2022-10-10 15:44 ` Soha Jin
2022-10-10 16:43 ` Russell King (Oracle)
2022-10-10 16:52 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0RNsZUnV0GJqIlO@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=soha@lohu.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox