Re: [PATCH v5 06/13] virt: gunyah: Identify hypervisor version

Greg Kroah-Hartman
2022-10-14T07:36:32Z

On Thu, Oct 13, 2022 at 04:00:10PM -0700, Elliot Berman wrote:
> On 10/10/2022 11:13 PM, Greg Kroah-Hartman wrote:
> > On Mon, Oct 10, 2022 at 05:08:33PM -0700, Elliot Berman wrote:
> >
> > EXPORT_SYMBOL_GPL()? I have to ask.
>
> typo only :)
>
> >
> > But why is it exported at all? No one is using it in this patch.
> >
> It's used later in the series by the message queue driver. The idea here now
> is that gunyah.ko is capable of identifying Gunyah and other drivers can
> check if they are individually compatible with the reported version of
> Gunyah.

Then export it when you use it. If we had taken just half of the
series, then this would be an export that no one used, which is not ok.

thanks,

greg k-h