From: Lee Jones <lee@kernel.org>
To: Richard Acayan <mailingradian@gmail.com>
Cc: linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v9 0/3] SDM670 Pin Control Driver
Date: Tue, 11 Oct 2022 08:35:52 +0100 [thread overview]
Message-ID: <Y0Uc2L3s8vx0Bfsh@google.com> (raw)
In-Reply-To: <20221010232225.209700-1-mailingradian@gmail.com>
On Mon, 10 Oct 2022, Richard Acayan wrote:
> > On Fri, 07 Oct 2022, Richard Acayan wrote:
> > > Richard Acayan (3):
> > > dt-bindings: pinctrl: qcom: add sdm670 pinctrl
> > > pinctrl: qcom: do not reinitialize gpio valid mask
> > > pinctrl: qcom: add sdm670 pinctrl
> > >
> > > .../bindings/pinctrl/qcom,sdm670-tlmm.yaml | 127 ++
> > > drivers/pinctrl/qcom/Kconfig | 9 +
> > > drivers/pinctrl/qcom/Makefile | 1 +
> > > drivers/pinctrl/qcom/pinctrl-msm.c | 3 +-
> > > drivers/pinctrl/qcom/pinctrl-sdm670.c | 1345 +++++++++++++++++
> >
> > And I'm receiving this because ... ?
>
> You wrote a patch a few years ago, then supposedly changed your email, and I
> wanted to know if there's anything we should consider before removing some of
> the code you wrote for it (in patch 2). After I added you as a recipient, it got
> a review tag, so I don't know what input you can give now (unless it's
> important). My bad for not removing you yet.
Actually that is a perfectly valid reason. Thank you for the
clarification. I (used to) receive 100's of reviews a week for
drivers that either have nothing to do with me or because I conducted
some basic clean-up / fixed warnings, etc. Since I changed my email
address, things have improved a great deal, which is why this stood
out.
So I believe that patch was written to support one of the Lenovo
laptops booting in ACPI mode. Please see sdm845_acpi_reserved_gpios
for reference. Please ensure your patch does not break this
use-case.
Bjorn (who has now reviewed) would know this best.
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2022-10-11 7:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 21:32 [PATCH v9 0/3] SDM670 Pin Control Driver Richard Acayan
2022-10-07 21:32 ` [PATCH v9 1/3] dt-bindings: pinctrl: qcom: add sdm670 pinctrl Richard Acayan
2022-10-07 21:32 ` [PATCH v9 2/3] pinctrl: qcom: do not reinitialize gpio valid mask Richard Acayan
2022-10-07 21:32 ` [PATCH v9 3/3] pinctrl: qcom: add sdm670 pinctrl Richard Acayan
2022-10-10 7:49 ` [PATCH v9 0/3] SDM670 Pin Control Driver Lee Jones
2022-10-10 23:22 ` Richard Acayan
2022-10-11 7:35 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0Uc2L3s8vx0Bfsh@google.com \
--to=lee@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailingradian@gmail.com \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox