From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70F06C433FE for ; Wed, 12 Oct 2022 14:50:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229771AbiJLOua (ORCPT ); Wed, 12 Oct 2022 10:50:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229744AbiJLOu1 (ORCPT ); Wed, 12 Oct 2022 10:50:27 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0C9640BFA; Wed, 12 Oct 2022 07:50:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2D413B81B34; Wed, 12 Oct 2022 14:50:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A283C433D6; Wed, 12 Oct 2022 14:50:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665586222; bh=eVKl0wqt9W+ZZ9zWc15s27SxTrfKi2PuqJ1GwfcNviw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y3GTmsFg9zuySZkZgvOYCgdgrRc1VQroZzkpifVrkvoGYatmDgweAWvOjfZKmPw5X ZuD3KsLgvB/MpUOyftWrdOedWgED/duw2zGIChHrucc5z4v/vbt+qYKgq2jlTsQvSe 1pkLLZ+vZq7lYqBr8mP9QYLINkgQCG+0EaPVua57MXE8u2Sa6TE3C4r2kX5Q6qron1 LXmgvAn4/W1/HJxGctgurtd4I86xISr/WIBoT8HZBwrC6eCc06CC1HV3pVpxgZgYkq SdozyyqzbAGQ5WHU0F+9m431kRadiEBY9gRz696p+X8x+RiPlg3J4OsUKfLYedV2Ia 794wGulGYaAbA== Date: Wed, 12 Oct 2022 17:50:19 +0300 From: Jarkko Sakkinen To: Dave Hansen Cc: Ira Weiny , Kristen Carlson Accardi , linux-kernel@vger.kernel.org, linux-sgx@vger.kernel.org, Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" Subject: Re: [PATCH] x86/sgx: Replace kmap/kunmap_atomic calls Message-ID: References: <20220929160647.362798-1-kristen@linux.intel.com> <711f8036-787a-571e-1c0d-1a258175ebb2@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <711f8036-787a-571e-1c0d-1a258175ebb2@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 12, 2022 at 07:13:26AM -0700, Dave Hansen wrote: > On 10/12/22 00:15, Jarkko Sakkinen wrote: > > There's no data to show that this change would be useful to do. > > Jarkko, I think the overall transition to kmap_local_page() is a good > one. It is a superior API and having it around will pave the way for > new features. I don't think we should demand 'data' for each and every > one of these. > > Please take a look around the tree and see how other maintainers are > handling these patches. They're not limited to SGX. Sure, I'll take a look for comparison. BR, Jarkko