From: Greg KH <gregkh@linuxfoundation.org>
To: Saurabh Sengar <ssengar@linux.microsoft.com>
Cc: ssengar@microsoft.com, kys@microsoft.com, haiyangz@microsoft.com,
sthemmin@microsoft.com, wei.liu@kernel.org, decui@microsoft.com,
longli@microsoft.com, linux-hyperv@vger.kernel.org,
linux-kernel@vger.kernel.org, mikelley@microsoft.com
Subject: Re: [PATCH] uio_hv_generic: Enable support for slower vmbus device channels
Date: Wed, 12 Oct 2022 17:52:05 +0200 [thread overview]
Message-ID: <Y0bipdisMbTNMYOq@kroah.com> (raw)
In-Reply-To: <1665575806-27990-1-git-send-email-ssengar@linux.microsoft.com>
On Wed, Oct 12, 2022 at 04:56:46AM -0700, Saurabh Sengar wrote:
> This patch enables support for slower vmbus channels, which consist
> of following 3 changes :
> 1. Support for hypercalls
> 2. Module params for recv/send buffer sizes
> 3. Module param for custom ring buffer sizes
Even if this all was ok, you are doing 3 things all in one change,
that's not allowed at all, you all know this.
Anyway, no new module parameters, this is not the 1990's, we have much
better ways to do this properly (hint, module parameters modify code,
you want to modify the options of a specific device.)
greg k-h
next prev parent reply other threads:[~2022-10-12 15:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 11:56 [PATCH] uio_hv_generic: Enable support for slower vmbus device channels Saurabh Sengar
2022-10-12 15:52 ` Greg KH [this message]
2022-10-12 15:54 ` Greg KH
2022-10-13 4:15 ` Saurabh Singh Sengar
2022-10-13 4:47 ` Greg KH
2022-10-12 17:42 ` kernel test robot
2022-10-12 18:14 ` kernel test robot
2022-10-12 20:30 ` kernel test robot
2022-10-13 13:48 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0bipdisMbTNMYOq@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=mikelley@microsoft.com \
--cc=ssengar@linux.microsoft.com \
--cc=ssengar@microsoft.com \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox