From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D469C433FE for ; Thu, 13 Oct 2022 18:36:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231628AbiJMSgJ (ORCPT ); Thu, 13 Oct 2022 14:36:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229815AbiJMSfj (ORCPT ); Thu, 13 Oct 2022 14:35:39 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27FE2192DAC; Thu, 13 Oct 2022 11:32:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2997AB8205A; Thu, 13 Oct 2022 17:59:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A15DBC433D7; Thu, 13 Oct 2022 17:59:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665683991; bh=YvzWFopE4vb9e3aO/bHq8nJsTi5w8TgSx11JN20VUpY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WBlfHyZlbueYhQzq0+dw9zi4dRKRhjWpF39CHEXPItnIE5QbDJp8KtE1+roeiP2V9 KcRmmmQ5UEaRq+EEdaOLjioirQkIFs8CzM6v8j+fH8o/LfekRSk8kApFah3+vJGiXL Wr1u+F8+Ltj/Nb9mhgOoz/smhwwjA++sz8ASJel2F/yj+268TKCQFMiYFw+eh5V2OM 7LXtkju2vNYwvJ6rYlWeUG196YSSPtI9z8w/qtBDpQG1mECXIkZ91VTgdcQ8+GxF2f 4nu6aqd0grVQjal4mzNAjLAt+q4Yytb1OyRCoY3Dowh7TkMXp7zo93/PkLCz22yi2u MAOLVv2gSpFhA== Date: Thu, 13 Oct 2022 13:59:50 -0400 From: Sasha Levin To: Richard Acayan Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Bhupesh Sharma , Krzysztof Kozlowski , Ulf Hansson , agross@kernel.org, andersson@kernel.org, adrian.hunter@intel.com, linux-arm-msm@vger.kernel.org, linux-mmc@vger.kernel.org Subject: Re: [PATCH AUTOSEL 6.0 39/44] mmc: sdhci-msm: add compatible string check for sdm670 Message-ID: References: <20221009234932.1230196-1-sashal@kernel.org> <20221009234932.1230196-39-sashal@kernel.org> <20221010234353.228833-1-mailingradian@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20221010234353.228833-1-mailingradian@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 10, 2022 at 07:43:53PM -0400, Richard Acayan wrote: >> From: Richard Acayan >> >> [ Upstream commit 4de95950d970c71a9e82a24573bb7a44fd95baa1 ] >> >> The Snapdragon 670 has the same quirk as Snapdragon 845 (needing to >> restore the dll config). Add a compatible string check to detect the need >> for this. >> >> Signed-off-by: Richard Acayan >> Reviewed-by: Bhupesh Sharma >> Acked-by: Krzysztof Kozlowski >> Link: https://lore.kernel.org/r/20220923014322.33620-3-mailingradian@gmail.com >> Signed-off-by: Ulf Hansson >> Signed-off-by: Sasha Levin >> --- >> drivers/mmc/host/sdhci-msm.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c >> index dc2991422a87..3a091a387ecb 100644 >> --- a/drivers/mmc/host/sdhci-msm.c >> +++ b/drivers/mmc/host/sdhci-msm.c >> @@ -2441,6 +2441,7 @@ static const struct of_device_id sdhci_msm_dt_match[] = { >> */ >> {.compatible = "qcom,sdhci-msm-v4", .data = &sdhci_msm_mci_var}, >> {.compatible = "qcom,sdhci-msm-v5", .data = &sdhci_msm_v5_var}, >> + {.compatible = "qcom,sdm670-sdhci", .data = &sdm845_sdhci_var}, > >Supporting device trees which are invalid under 6.0 schema? It's not a bug fix, >it's a feature. Does this not enable hardware to work properly? We take quirks/device enablement into stable tree as well. -- Thanks, Sasha