Re: [PATCH AUTOSEL 6.0 17/77] genetlink: hold read cb_lock during iteration of genl_fam_idr in genl_bind()

Sasha Levin
2022-10-13T18:22:30Z

On Mon, Oct 10, 2022 at 08:49:46AM -0700, Jakub Kicinski wrote:
>On Sun, 9 Oct 2022 18:06:54 -0400 Sasha Levin wrote:
>> In genl_bind(), currently genl_lock and write cb_lock are taken
>> for iteration of genl_fam_idr and processing of static values
>> stored in struct genl_family. Take just read cb_lock for this task
>> as it is sufficient to guard the idr and the struct against
>> concurrent genl_register/unregister_family() calls.
>>
>> This will allow to run genl command processing in genl_rcv() and
>> mnl_socket_setsockopt(.., NETLINK_ADD_MEMBERSHIP, ..) in parallel.
>
>Not stable material, please drop.

Will do, thanks!

--
Thanks,
Sasha