From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57590C4332F for ; Sat, 15 Oct 2022 17:27:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229720AbiJOR1O (ORCPT ); Sat, 15 Oct 2022 13:27:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229504AbiJOR1M (ORCPT ); Sat, 15 Oct 2022 13:27:12 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50255275C8 for ; Sat, 15 Oct 2022 10:27:11 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2A3D0480; Sat, 15 Oct 2022 19:27:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1665854829; bh=eiQiH8zroSayUVnkdP1tcEEZ3b9arQTFKuV0xO9DL8M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P4vdH6WzRd476+zgFPcIahs6DfK3ttXeSiFQdrcyLQnlmJVeX4X8ymKtj7dckqDx5 XP6tw6VLC4XqZQuT+yijVfLujZUL+hpcdNnAqOJuay6UmIlXtQm4RLTkdsQue5xX2n nIo2O6tQ3iCLNtm5qoxnGidF0nRopajV7JrextwM= Date: Sat, 15 Oct 2022 20:26:46 +0300 From: Laurent Pinchart To: Maxime Ripard Cc: Maxime Ripard , Eric Anholt , Daniel Vetter , David Airlie , Rob Herring , Emma Anholt , dri-devel@lists.freedesktop.org, Joerg Quinten , Chris Morgan , Dave Stevenson , linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/7] drm/vc4: dpi: Support BGR666 formats Message-ID: References: <20221013-rpi-dpi-improvements-v1-0-8a7a96949cb0@cerno.tech> <20221013-rpi-dpi-improvements-v1-5-8a7a96949cb0@cerno.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221013-rpi-dpi-improvements-v1-5-8a7a96949cb0@cerno.tech> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maxime and Joerg, Thank you for the patch. On Thu, Oct 13, 2022 at 11:56:49AM +0200, Maxime Ripard wrote: > From: Joerg Quinten > > The VC4 DPI output can support multiple BGR666 variants, but they were > never added to the driver. Let's add the the support for those formats. > > Signed-off-by: Joerg Quinten > Signed-off-by: Maxime Ripard Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/vc4/vc4_dpi.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c > index 7da3dd1db50e..ecbe4cd87036 100644 > --- a/drivers/gpu/drm/vc4/vc4_dpi.c > +++ b/drivers/gpu/drm/vc4/vc4_dpi.c > @@ -170,10 +170,16 @@ static void vc4_dpi_encoder_enable(struct drm_encoder *encoder) > dpi_c |= VC4_SET_FIELD(DPI_ORDER_BGR, > DPI_ORDER); > break; > + case MEDIA_BUS_FMT_BGR666_1X24_CPADHI: > + dpi_c |= VC4_SET_FIELD(DPI_ORDER_BGR, DPI_ORDER); > + fallthrough; > case MEDIA_BUS_FMT_RGB666_1X24_CPADHI: > dpi_c |= VC4_SET_FIELD(DPI_FORMAT_18BIT_666_RGB_2, > DPI_FORMAT); > break; > + case MEDIA_BUS_FMT_BGR666_1X18: > + dpi_c |= VC4_SET_FIELD(DPI_ORDER_BGR, DPI_ORDER); > + fallthrough; > case MEDIA_BUS_FMT_RGB666_1X18: > dpi_c |= VC4_SET_FIELD(DPI_FORMAT_18BIT_666_RGB_1, > DPI_FORMAT); > -- Regards, Laurent Pinchart