Re: [PATCH v3 3/5] dt-bindings: regulator: Add binding schema for mt6357 regulators

Rob Herring
2022-10-21T01:05:22Z

On Thu, Oct 20, 2022 at 06:20:47PM +0200, Alexandre Mergnat wrote:
> From: Fabien Parent <fparent@baylibre.com>
>
> Add YAML schema for the MediaTek MT6357 regulators.
>
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
> .../regulator/mediatek,mt6357-regulator.yaml | 292 +++++++++++++++++++++
> 1 file changed, 292 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/regulator/mediatek,mt6357-regulator.yaml b/Documentation/devicetree/bindings/regulator/mediatek,mt6357-regulator.yaml
> new file mode 100644
> index 000000000000..8dc1245304be
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt6357-regulator.yaml
> @@ -0,0 +1,292 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/mediatek,mt6357-regulator.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek MT6357 Regulators
> +
> +maintainers:
> + - Fabien Parent <fabien.parent@linaro.org>
> + - Alexandre Mergnat <amergnat@baylibre.com>
> +
> +description: |
> + The MT6357 PMIC provides 5 BUCK and 29 LDO.
> + Regulators and nodes are named according to the regulator type:
> + buck-<name> and ldo-<name>.
> + MT6357 regulators node should be sub node of the MT6397 MFD node.
> +
> +patternProperties:
> + "^buck-v(core|modem|pa|proc|s1)$":
> + type: object
> + $ref: regulator.yaml#
> + unevaluatedProperties: false
> + description:
> + Properties for single BUCK regulator.
> +
> + required:
> + - regulator-name
> + - regulator-min-microvolt
> + - regulator-max-microvolt
> +
> + "^ldo-v(aud28|aux18|cama|camd|cn18|cn28|cn33-bt|cn33-wifi|dram)$":
> + type: object
> + $ref: regulator.yaml#
> + unevaluatedProperties: false
> + description:
> + Properties for single LDO regulator.
> +
> + required:
> + - regulator-name
> + - regulator-min-microvolt
> + - regulator-max-microvolt
> +
> + "^ldo-v(efuse|emc|ibr|io18|io28|ldo28|mch|rf12|rf18)$":

vf12 and rf18 are covered by regulator-fixed binding.

> + type: object
> + $ref: regulator.yaml#
> + unevaluatedProperties: false
> + description:
> + Properties for single LDO regulator.
> +
> + required:
> + - regulator-name
> + - regulator-min-microvolt
> + - regulator-max-microvolt
> +
> + "^ldo-v(xo22|sim1,sim2|sram-others|sram-proc|usb33|xo22)$":
> + type: object
> + $ref: regulator.yaml#
> + unevaluatedProperties: false
> + description:
> + Properties for single LDO regulator.
> +
> + required:
> + - regulator-name
> + - regulator-min-microvolt
> + - regulator-max-microvolt
> +
> +additionalProperties: false

vfe28 is not listed, and this would cause an error if the schema was
applied, but it is not as Krzysztof pointed out.

The MFD binding really needs to be converted so it can reference this
schema. Otherwise, when it is, then all the issues have to be fixed.

Rob