From: Jiri Olsa <olsajiri@gmail.com>
To: David Laight <David.Laight@aculab.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: Linux 6.1-rc3 build fail in include/linux/bpf.h
Date: Mon, 31 Oct 2022 13:17:16 +0100 [thread overview]
Message-ID: <Y1+8zIdf8mgQXwHg@krava> (raw)
In-Reply-To: <439d8dc735bb4858875377df67f1b29a@AcuMS.aculab.com>
On Mon, Oct 31, 2022 at 11:14:31AM +0000, David Laight wrote:
> The 6.1-rc3 sources fail to build because bpf.h unconditionally
> #define BPF_DISPATCHER_ATTRIBUTES __attribute__((patchable_function_entry(5)))
> for X86_64 builds.
>
> I'm pretty sure that should depend on some other options
> since the compiler isn't required to support it.
> (The gcc 7.5.0 on my Ubunti 18.04 system certainly doesn't)
>
> The only other reference to that attribute is in the definition
> of 'notrace' in compiler.h.
I guess we need to make some __has_attribute check and make all that conditional
cc-ing Peter
jirka
>
> David
>
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
>
next prev parent reply other threads:[~2022-10-31 12:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 11:14 Linux 6.1-rc3 build fail in include/linux/bpf.h David Laight
2022-10-31 12:03 ` David Laight
2022-10-31 12:17 ` Jiri Olsa [this message]
2022-10-31 15:21 ` Peter Zijlstra
2022-10-31 21:53 ` Jiri Olsa
2022-11-01 11:00 ` Björn Töpel
2022-11-01 13:39 ` Björn Töpel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1+8zIdf8mgQXwHg@krava \
--to=olsajiri@gmail.com \
--cc=David.Laight@aculab.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox