From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85FF6FA3740 for ; Mon, 31 Oct 2022 08:28:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229866AbiJaI2z (ORCPT ); Mon, 31 Oct 2022 04:28:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229628AbiJaI2v (ORCPT ); Mon, 31 Oct 2022 04:28:51 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2F5CD260C for ; Mon, 31 Oct 2022 01:28:49 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 568F080CD; Mon, 31 Oct 2022 08:19:20 +0000 (UTC) Date: Mon, 31 Oct 2022 10:28:47 +0200 From: Tony Lindgren To: Yang Yingliang Cc: linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org, tglx@linutronix.de Subject: Re: [PATCH v2] clocksource/drivers/timer-ti-dm: fix missing clk_disable_unprepare in dmtimer_systimer_init_clock() Message-ID: References: <20221029114427.946520-1-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221029114427.946520-1-yangyingliang@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Yang Yingliang [221029 11:36]: > If clk_get_rate() fails which is called after clk_prepare_enable(), > clk_disable_unprepare() need be called in error path to disable the > clock in dmtimer_systimer_init_clock(). Reviewed-by: Tony Lindgren