Re: [PATCH printk v2 32/38] printk: __pr_flush: use srcu console list iterator

Petr Mladek
2022-10-26T08:33:22Z

On Wed 2022-10-19 17:01:54, John Ogness wrote:
> Use srcu console list iteration for console list traversal.
>
> Document why the console_lock is still necessary.

When thinking about it. It might be worth explaining why the srcu
traversal is added even when console_lock is still needed.
It would make the life of code archaeologists easier.

I mean to add a note that it will keep the traversal safe
even after console_drivers list manipulation will not longer be
serialized using console_lock(). Or something like this.

It would be nice to add this to all other patches the introduced
srcu and kept console_lock.

> Signed-off-by: John Ogness <john.ogness@linutronix.de>

Anyway, the change looks good. Feel free to use:

Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr