From: Christoph Hellwig <hch@infradead.org>
To: Niklas Schnelle <schnelle@linux.ibm.com>
Cc: Matthew Rosato <mjrosato@linux.ibm.com>,
iommu@lists.linux.dev, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Gerd Bayer <gbayer@linux.ibm.com>,
Pierre Morel <pmorel@linux.ibm.com>,
linux-s390@vger.kernel.org, borntraeger@linux.ibm.com,
hca@linux.ibm.com, gor@linux.ibm.com,
gerald.schaefer@linux.ibm.com, agordeev@linux.ibm.com,
svens@linux.ibm.com, linux-kernel@vger.kernel.org,
Wenjia Zhang <wenjia@linux.ibm.com>,
Julian Ruess <julianr@linux.ibm.com>
Subject: Re: [RFC 1/6] s390/ism: Set DMA coherent mask
Date: Thu, 20 Oct 2022 01:07:50 -0700 [thread overview]
Message-ID: <Y1EB1pvWkoHXQh+a@infradead.org> (raw)
In-Reply-To: <20221019144435.369902-2-schnelle@linux.ibm.com>
On Wed, Oct 19, 2022 at 04:44:30PM +0200, Niklas Schnelle wrote:
> if (ret)
> goto err_resource;
>
> + ret = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(64));
Nit: but you could also just replace the call to dma_set_mask abobe with
a call to dma_set_mask_and_coherent.
next prev parent reply other threads:[~2022-10-20 8:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 14:44 [RFC 0/6] iommu/dma: s390 DMA API conversion and optimized IOTLB flushing Niklas Schnelle
2022-10-19 14:44 ` [RFC 1/6] s390/ism: Set DMA coherent mask Niklas Schnelle
2022-10-20 8:07 ` Christoph Hellwig [this message]
2022-10-20 12:16 ` Niklas Schnelle
2022-10-19 14:44 ` [RFC 2/6] s390/pci: prepare is_passed_through() for dma-iommu Niklas Schnelle
2022-10-19 14:44 ` [RFC 3/6] s390/pci: Use dma-iommu layer Niklas Schnelle
2022-10-19 14:44 ` [RFC 4/6] iommu/dma: Prepare for multiple flush queue implementations Niklas Schnelle
2022-10-19 14:44 ` [RFC 5/6] iommu/dma: Add simple batching flush queue implementation Niklas Schnelle
2022-10-20 13:18 ` Robin Murphy
2022-10-20 15:36 ` Niklas Schnelle
2022-10-19 14:44 ` [RFC 6/6] iommu/s390: flush queued IOVAs on RPCIT out of resource indication Niklas Schnelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1EB1pvWkoHXQh+a@infradead.org \
--to=hch@infradead.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gbayer@linux.ibm.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=julianr@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=robin.murphy@arm.com \
--cc=schnelle@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=wenjia@linux.ibm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox