From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C0A1C43217 for ; Thu, 20 Oct 2022 09:31:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230285AbiJTJbK (ORCPT ); Thu, 20 Oct 2022 05:31:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229587AbiJTJbH (ORCPT ); Thu, 20 Oct 2022 05:31:07 -0400 Received: from metanate.com (unknown [IPv6:2001:8b0:1628:5005::111]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25BFC1413B9 for ; Thu, 20 Oct 2022 02:31:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=metanate.com; s=stronger; h=In-Reply-To:Content-Type:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description; bh=IqJ+PXWSgAwEtUKSxNWOIpPEVROLORYHEj928+nb8F0=; b=mA+cP 1Th1gRoOUnc4A4HI5zcTh4Qmq14q9vYCyFAGndWmeeQF9c9tbs283dNbMo0vOcljn/PaCnsvgCavd Vb8bmLkUYczh77aCyJg6rCfkx8Q9wRveH3TF1HvI901VLgXuPlqw+AUF0TzoAegl9NXlDhSjckzJ4 5ttxSjMy7IP0T5Yev8vyLDqli4wYJjnEx7SgOCAfC4mjZOjCKK5ArFSKM0+rSkl/TJs8ISnQTB2L9 /vE6Wjr4vroB/s0cEnBGdBnPG/SH+C1XP071rXyKgfA9Kxedl0CvfVp0r4N8drQEwpPEeMTRqlZ+8 uv0pOaaQ80h5yWNhw75uke7Yy7t+A==; Received: from [81.174.171.191] (helo=donbot) by email.metanate.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1olRt2-0007uq-8e; Thu, 20 Oct 2022 10:30:49 +0100 Date: Thu, 20 Oct 2022 10:30:48 +0100 From: John Keeping To: Johan Jonker Cc: heiko@sntech.de, hjc@rock-chips.com, airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] drm: rockchip: remove rockchip_drm_framebuffer_init() function Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Authenticated: YES Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 19, 2022 at 11:35:03PM +0200, Johan Jonker wrote: > The function rockchip_drm_framebuffer_init() was in use > in the rockchip_drm_fbdev.c file, but that is now replaced > by a generic fbdev setup. Reduce the image size by > removing the rockchip_drm_framebuffer_init() and sub function > rockchip_fb_alloc() and cleanup the rockchip_drm_fb.h header file. > > Signed-off-by: Johan Jonker Reviewed-by: John Keeping > --- > drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 43 ---------------------- > drivers/gpu/drm/rockchip/rockchip_drm_fb.h | 6 --- > 2 files changed, 49 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c > index 092bf863110b..409eaa1bf092 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c > @@ -25,35 +25,6 @@ static const struct drm_framebuffer_funcs rockchip_drm_fb_funcs = { > .dirty = drm_atomic_helper_dirtyfb, > }; > > -static struct drm_framebuffer * > -rockchip_fb_alloc(struct drm_device *dev, const struct drm_mode_fb_cmd2 *mode_cmd, > - struct drm_gem_object **obj, unsigned int num_planes) > -{ > - struct drm_framebuffer *fb; > - int ret; > - int i; > - > - fb = kzalloc(sizeof(*fb), GFP_KERNEL); > - if (!fb) > - return ERR_PTR(-ENOMEM); > - > - drm_helper_mode_fill_fb_struct(dev, fb, mode_cmd); > - > - for (i = 0; i < num_planes; i++) > - fb->obj[i] = obj[i]; > - > - ret = drm_framebuffer_init(dev, fb, &rockchip_drm_fb_funcs); > - if (ret) { > - DRM_DEV_ERROR(dev->dev, > - "Failed to initialize framebuffer: %d\n", > - ret); > - kfree(fb); > - return ERR_PTR(ret); > - } > - > - return fb; > -} > - > static const struct drm_mode_config_helper_funcs rockchip_mode_config_helpers = { > .atomic_commit_tail = drm_atomic_helper_commit_tail_rpm, > }; > @@ -106,20 +77,6 @@ static const struct drm_mode_config_funcs rockchip_drm_mode_config_funcs = { > .atomic_commit = drm_atomic_helper_commit, > }; > > -struct drm_framebuffer * > -rockchip_drm_framebuffer_init(struct drm_device *dev, > - const struct drm_mode_fb_cmd2 *mode_cmd, > - struct drm_gem_object *obj) > -{ > - struct drm_framebuffer *fb; > - > - fb = rockchip_fb_alloc(dev, mode_cmd, &obj, 1); > - if (IS_ERR(fb)) > - return ERR_CAST(fb); > - > - return fb; > -} > - > void rockchip_drm_mode_config_init(struct drm_device *dev) > { > dev->mode_config.min_width = 0; > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fb.h b/drivers/gpu/drm/rockchip/rockchip_drm_fb.h > index 1a696521096d..bae4e079dfb1 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_fb.h > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_fb.h > @@ -7,11 +7,5 @@ > #ifndef _ROCKCHIP_DRM_FB_H > #define _ROCKCHIP_DRM_FB_H > > -struct drm_framebuffer * > -rockchip_drm_framebuffer_init(struct drm_device *dev, > - const struct drm_mode_fb_cmd2 *mode_cmd, > - struct drm_gem_object *obj); > -void rockchip_drm_framebuffer_fini(struct drm_framebuffer *fb); > - > void rockchip_drm_mode_config_init(struct drm_device *dev); > #endif /* _ROCKCHIP_DRM_FB_H */ > -- > 2.20.1 >